Skip to content

Update CRDs#459

Closed
tnozicka wants to merge 10 commits intoopenshift:masterfrom
tnozicka:update-crds
Closed

Update CRDs#459
tnozicka wants to merge 10 commits intoopenshift:masterfrom
tnozicka:update-crds

Conversation

@tnozicka
Copy link
Copy Markdown
Contributor

@tnozicka tnozicka commented Oct 7, 2019

/cc @damemi

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 7, 2019
@tnozicka tnozicka changed the title [WIP] Update crds Update crds Oct 7, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2019
@tnozicka tnozicka changed the title Update crds Update CRDs Oct 7, 2019
@tnozicka
Copy link
Copy Markdown
Contributor Author

tnozicka commented Oct 8, 2019 •
edited
Loading

/cc @deads2k

@openshift/sig-master (for the pattern awareness)

@tnozicka
Copy link
Copy Markdown
Contributor Author

tnozicka commented Oct 8, 2019

/assign @deads2k

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Oct 15, 2019

/lgtm

@damemi likes the build files.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2019
@damemi damemi mentioned this pull request Oct 15, 2019
Merged
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Oct 15, 2019

/test all

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Oct 15, 2019

Superseded by #470
/close

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 15, 2019

@soltysh: Closed this PR.

Details

In response to this:

Superseded by #470
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 15, 2019

@tnozicka: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/verify d87d03b link /test verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tnozicka tnozicka deleted the update-crds branch October 23, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damemi damemi Awaiting requested review from damemi

Assignees

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tnozicka @deads2k @openshift-ci-robot @soltysh