Fix npm test (karma-webpack): delete karma-webpack patch, as 5.0.1 works out of the box#1509
Merged
Conversation
added 3 commits
February 1, 2024 22:47
…d have fixed the MacOS build issue
…users who had 5.0.0 installed without this, npm install didn't update to 5.0.1 if you already had 5.0.0 installed. since we removed the patch, 5.0.1 should be used, as 5.0.0 patch-less can fail on MacOS when running from different drives/mounts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
karma-webpack 5.0.1, released a few hours ago, failed npm test, and with that, our CI builds.
It is incompatible with the patch we used for it, but it seems to work out of the box patch-less, so we can just remove our patch.
We originally added the patch because karma-webpack 5.0.0 had build issues on MacOS (with different drives/mounts), but it looks like they fixed that in 5.0.1.
Original OSMD patch issue: #1119