dependencies: update to webpack 5, patch karma-webpack#1119
Merged
Conversation
…6, etc. (#1105) this needs an upcoming fix to karma-webpack 5.0 in a further commit, see here: #1105 (comment) * npm-upgrade * timeout increased * process.env is not defined * generateImages_browserles migrated to mjs * review comments * npm-upgrade (cherry picked from commit 801b44a)
added 2 commits
January 8, 2022 00:00
This reverts commit 75777bd.
This reverts commit 5fd2b5a. turns out the problem is in webpack (bundling), not in karma-webpack. and it looks like it's not simple to fix: webpack/webpack#12759 So we'll have to give up windows multiple drive support for now, this is the easiest option, as it works on MacOS (with patch) and Linux now.
Contributor
Author
|
Turns out the npm test error in Windows comes from webpack, not directly from karma-webpack, So we'll have to give up windows multiple drive support for now and just merge this, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes Npm updates from #1105, which was first merged to feat/webpack5.
Karma-webpack 5.0 needs some patches to work correctly with Windows and MacOS file paths, which are now complete.