Move some maintainers from active to Emeritus by LantaoJin · Pull Request #5260 · opensearch-project/sql

LantaoJin · 2026-03-24T08:35:58Z

Description

Move inactive maintainers (@kavithacm, @derek-ho, @YANG-DB, @seankao-az, @MaxKsyunz, @Yury-Fridlyand, @forestmvey, @GumpacG) to Emeritus. ref

2. Remove affiliation column for emeritus maintainers

Related Issues

Resolves "LF license quota issue"

Check List

New functionality includes testing.
New functionality has been documented.
New functionality has javadoc added.
New functionality has a user manual doc added.
New PPL command checklist all confirmed.
API changes companion pull request created.
Commits are signed per the DCO using --signoff or -s.
Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Lantao Jin <ltjin@amazon.com>

github-actions · 2026-03-24T08:37:10Z

PR Reviewer Guide 🔍

(Review updated until commit `1ed4502`)

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

github-actions · 2026-03-24T08:37:26Z

PR Code Suggestions ✨

Latest suggestions up to 1ed4502

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Restore missing table column header The Emeritus Maintainers table header is missing the `Affiliation` column that exists in the Active Maintainers table. This inconsistency breaks the table structure since the existing emeritus entries previously had an `Affiliation` column. Adding it back maintains consistency with the rest of the document. MAINTAINERS.md [29-30] -\| Maintainer \| GitHub ID \| -\| ----------------- \| ------------------------------------------------------- \| +\| Maintainer \| GitHub ID \| Affiliation \| +\| ----------------- \| ------------------------------------------------------- \| ----------- \| Suggestion importance[1-10]: 4 __ Why: The Emeritus Maintainers table is missing the `Affiliation` column header that was present in the old version. However, looking at the new emeritus entries (lines 31-46), none of them include an affiliation column value, so adding the header without corresponding data in each row would create an inconsistent table. The suggestion is partially valid but incomplete.	Low

Previous suggestions

Suggestions up to commit 2683713

Category	Suggestion	Impact
General	Restore missing table column header The Emeritus Maintainers table header is missing the `Affiliation` column that exists in the Active Maintainers table. This inconsistency could be confusing, and the column should either be retained (even if left blank) or intentionally removed from both tables for consistency. MAINTAINERS.md [29-30] -\| Maintainer \| GitHub ID \| -\| ----------------- \| ------------------------------------------------------- \| +\| Maintainer \| GitHub ID \| Affiliation \| +\| ----------------- \| ------------------------------------------------------- \| ----------- \| Suggestion importance[1-10]: 4 __ Why: The Emeritus Maintainers table is missing the `Affiliation` column header that was present in the old version. However, looking at the PR diff, the emeritus entries themselves don't include an affiliation column either, so this appears to be an intentional design choice to remove affiliation from the emeritus table. The suggestion has some merit for consistency but may not reflect the PR's intent.	Low

Suggestions up to commit 6f8463d

Category	Suggestion	Impact
General	Restore missing column for table consistency The Emeritus Maintainers table header is missing the `Affiliation` column that exists in the active Maintainers table. While emeritus maintainers may no longer be affiliated, removing the column creates an inconsistent table structure. Consider keeping the column for consistency, or this is an intentional change that should be verified. MAINTAINERS.md [28-29] -\| Maintainer \| GitHub ID \| -\| ----------------- \| ------------------------------------------------------- \| +\| Maintainer \| GitHub ID \| Affiliation \| +\| ----------------- \| ------------------------------------------------------- \| ----------- \| Suggestion importance[1-10]: 4 __ Why: The Emeritus Maintainers table is missing the `Affiliation` column that exists in the active Maintainers table. This is a valid consistency concern, though it may be intentional since emeritus maintainers' affiliations may be less relevant.	Low
General	Add missing newline at end of file The file is missing a newline at the end, as indicated by the "No newline at end of file" warning. Files should end with a newline character to follow standard text file conventions and avoid potential issues with tools that process the file. MAINTAINERS.md [45] +\| Guian Gumpac \| [GumpacG](https://github.com/GumpacG) \| - Suggestion importance[1-10]: 2 __ Why: The `existing_code` and `improved_code` are identical, meaning no actual change is demonstrated. The suggestion about a missing newline is valid in principle but the improved code doesn't show the fix.	Low

Suggestions up to commit a944399

Category	Suggestion	Impact
General	Restore missing Affiliation column in Emeritus table The Emeritus Maintainers table header is missing the `Affiliation` column that exists in the active Maintainers table. The newly added emeritus maintainers also lack affiliation data. For consistency, either retain the `Affiliation` column (even if left blank) or ensure the table structure is intentionally different. MAINTAINERS.md [28-29] -\| Maintainer \| GitHub ID \| -\| ----------------- \| ------------------------------------------------------- \| +\| Maintainer \| GitHub ID \| Affiliation \| +\| ----------------- \| ------------------------------------------------------- \| ----------- \| Suggestion importance[1-10]: 4 __ Why: The PR intentionally removed the `Affiliation` column from the Emeritus Maintainers table header, which creates an inconsistency with the active maintainers table. This is a valid consistency concern, though it may be an intentional design choice.	Low
General	Add missing newline at end of file The file is missing a newline at the end, as indicated by the "No newline at end of file" warning. Most style guides and tools expect files to end with a newline character. Add a newline after the last line. MAINTAINERS.md [45] +\| Guian Gumpac \| [GumpacG](https://github.com/GumpacG) \| - Suggestion importance[1-10]: 2 __ Why: The `existing_code` and `improved_code` are identical, meaning the suggestion doesn't actually demonstrate the fix. Additionally, this is a minor formatting issue with minimal impact on functionality.	Low

Signed-off-by: Lantao Jin <ltjin@amazon.com>

github-actions · 2026-03-24T08:40:48Z

Persistent review updated to latest commit 6f8463d

LantaoJin · 2026-03-24T08:44:48Z

cc @peterzhuamazon

Swiddis

merge conflicts with songkan's addition

Signed-off-by: Simeon Widdis <sawiddis@gmail.com>

github-actions · 2026-03-24T19:28:11Z

Persistent review updated to latest commit 2683713

github-actions · 2026-03-24T19:28:20Z

Persistent review updated to latest commit 2683713

Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com>

github-actions · 2026-03-24T19:31:26Z

Persistent review updated to latest commit 1ed4502

* Init CLAUDE.md (#5259) Signed-off-by: Heng Qian <qianheng@amazon.com> * Add label to exempt specific PRs from stalled labeling (#5263) * Implement `reverse` performance optimization (#4775) Co-authored-by: Jialiang Liang <jiallian@amazon.com> * Add songkant-aws as maintainer (#5244) * Move some maintainers from active to Emeritus (#5260) * Move inactive current maintainers to Emeritus Signed-off-by: Lantao Jin <ltjin@amazon.com> * Remove affiliation column for emeritus maintainers Signed-off-by: Lantao Jin <ltjin@amazon.com> * formatted Signed-off-by: Lantao Jin <ltjin@amazon.com> * Fix formatting in MAINTAINERS.md Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: Simeon Widdis <sawiddis@gmail.com> * Add query cancellation support via _tasks/_cancel API for PPL queries (#5254) * Add query cancellation support via _tasks/_cancel API for PPL queries Signed-off-by: Sunil Ramchandra Pawar <pawar_sr@apple.com> * Refactor PPL query cancellation to cooperative model and other PR suggestions. Signed-off-by: Sunil Ramchandra Pawar <pawar_sr@apple.com> --------- Signed-off-by: Sunil Ramchandra Pawar <pawar_sr@apple.com> * Add Calcite native SQL planning in UnifiedQueryPlanner (#5257) * feat(api): Add Calcite native SQL planning path in UnifiedQueryPlanner Add SQL support to the unified query API using Calcite's native parser pipeline (SqlParser → SqlValidator → SqlToRelConverter → RelNode), bypassing the ANTLR parser used by PPL. Changes: - UnifiedQueryPlanner: use PlanningStrategy to dispatch CalciteNativeStrategy vs CustomVisitorStrategy - CalciteNativeStrategy: Calcite Planner with try-with-resources for ANSI SQL - CustomVisitorStrategy: ANTLR-based path for PPL (and future SQL V2) - UnifiedQueryContext: SqlParser.Config with Casing.UNCHANGED to preserve lowercase OpenSearch index names Signed-off-by: Chen Dai <daichen@amazon.com> * test(api): Add SQL planner tests and refactor test base for multi-language support - Refactor UnifiedQueryTestBase with queryType() hook for subclass override - Add UnifiedSqlQueryPlannerTest covering SELECT, WHERE, GROUP BY, JOIN, ORDER BY, subquery, case sensitivity, namespaces, and error handling - Update UnifiedQueryContextTest to verify SQL context creation Signed-off-by: Chen Dai <daichen@amazon.com> * perf(benchmarks): Add SQL queries to UnifiedQueryBenchmark Add language (PPL/SQL) and queryPattern param dimensions for side-by-side comparison of equivalent queries across both languages. Remove separate UnifiedSqlQueryBenchmark in favor of unified class. Signed-off-by: Chen Dai <daichen@amazon.com> * docs(api): Update README to reflect SQL support in UnifiedQueryPlanner Signed-off-by: Chen Dai <daichen@amazon.com> * fix(api): Normalize trailing whitespace in assertPlan comparison RelOptUtil.toString() appends a trailing newline after the last plan node, which doesn't match Java text block expectations. Also add \r\n normalization for Windows CI compatibility, consistent with the existing pattern in core module tests. Signed-off-by: Chen Dai <daichen@amazon.com> --------- Signed-off-by: Chen Dai <daichen@amazon.com> * [Feature] Support graphLookup with literal value as its start (#5253) * [Feature] Support graphLookup as top-level PPL command (#5243) Add support for graphLookup as the first command in a PPL query with literal start values, instead of requiring piped input from source=. Syntax: graphLookup table start="value" edge=from-->to as output graphLookup table start=("v1", "v2") edge=from-->to as output Signed-off-by: Heng Qian <qianheng@amazon.com> * Spotless check Signed-off-by: Heng Qian <qianheng@amazon.com> * Ignore child pipe if using start value Signed-off-by: Heng Qian <qianheng@amazon.com> * Add graphLookup integration tests per PPL command checklist - Add explain plan tests in CalciteExplainIT with YAML assertions - Add v2-unsupported tests in NewAddedCommandsIT - Add CalcitePPLGraphLookupIT to CalciteNoPushdownIT suite - Skip graphLookup tests when pushdown is disabled (required by impl) - Add expected plan YAML files for piped and top-level graphLookup Signed-off-by: Heng Qian <qianheng@amazon.com> * Remove brace of start value list Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com> * Apply docs website feedback to ppl functions (#5207) * apply doc website feedback to ppl functions Signed-off-by: Ritvi Bhatt <ribhatt@amazon.com> * take out comments Signed-off-by: Ritvi Bhatt <ribhatt@amazon.com> * fix json_append example Signed-off-by: Ritvi Bhatt <ribhatt@amazon.com> * fix json_append example Signed-off-by: Ritvi Bhatt <ribhatt@amazon.com> * fix links Signed-off-by: Ritvi Bhatt <ribhatt@amazon.com> --------- Signed-off-by: Ritvi Bhatt <ribhatt@amazon.com> Signed-off-by: ritvibhatt <53196324+ritvibhatt@users.noreply.github.com> * feat(api): Add profiling support to unified query API (#5268) Add query profiling infrastructure that measures time spent in each query phase (analyze, optimize, execute, format). Profiling is opt-in via UnifiedQueryContext.builder().profiling(true) and uses thread-local context to avoid passing profiling state through every method. Key changes: - QueryProfiling/ProfileContext for thread-local profiling lifecycle - UnifiedQueryContext.measure() API for timing arbitrary phases - Auto-profiling in UnifiedQueryPlanner (analyze) and compiler (optimize) - UnifiedQueryTestBase shared test fixture for unified query tests - Comprehensive profiling tests with non-flaky >= 0 timing assertions Signed-off-by: Chen Dai <daichen@amazon.com> * Add UnifiedQueryParser with language-specific implementations (#5274) Extract parsing logic from UnifiedQueryPlanner into a UnifiedQueryParser interface with language-specific implementations: PPLQueryParser (returns UnresolvedPlan) and CalciteSqlQueryParser (returns SqlNode). UnifiedQueryContext owns the parser instance, created eagerly by the builder which has direct access to query type and future SQL config. Each implementation receives only its required dependencies: PPLQueryParser takes Settings, CalciteSqlQueryParser takes CalcitePlanContext. UnifiedQueryPlanner.CustomVisitorStrategy now obtains the parser from the context via the interface type. Signed-off-by: Chen Dai <daichen@amazon.com> * Fix flaky TPC-H Q1 test due to bugs in `MatcherUtils.closeTo()` (#5283) * Fix the flaky tpch Q1 Signed-off-by: Lantao Jin <ltjin@amazon.com> * Change to ULP-aware to handle floating-point precision differences Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com> Signed-off-by: Lantao Jin <ltjin@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Signed-off-by: Sunil Ramchandra Pawar <pawar_sr@apple.com> Signed-off-by: Chen Dai <daichen@amazon.com> Signed-off-by: Ritvi Bhatt <ribhatt@amazon.com> Signed-off-by: ritvibhatt <53196324+ritvibhatt@users.noreply.github.com> Signed-off-by: Kai Huang <ahkcs@amazon.com> Co-authored-by: qianheng <qianheng@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: Jialiang Liang <jiallian@amazon.com> Co-authored-by: Lantao Jin <ltjin@amazon.com> Co-authored-by: Sunil Ramchandra Pawar <pawar_sr@apple.com> Co-authored-by: Chen Dai <daichen@amazon.com> Co-authored-by: ritvibhatt <53196324+ritvibhatt@users.noreply.github.com>

LantaoJin added 2 commits March 24, 2026 16:23

Move inactive current maintainers to Emeritus

756f1ef

Signed-off-by: Lantao Jin <ltjin@amazon.com>

Remove affiliation column for emeritus maintainers

a944399

Signed-off-by: Lantao Jin <ltjin@amazon.com>

formatted

6f8463d

Signed-off-by: Lantao Jin <ltjin@amazon.com>

LantaoJin added maintenance Improves code quality, but not the product skip-changelog labels Mar 24, 2026

LantaoJin mentioned this pull request Mar 24, 2026

[GitHub Request] Add new maintainers and update Emeritus list for SQL repo opensearch-project/.github#481

Closed

LantaoJin changed the title ~~Move inactive current maintainers to Emeritus~~ Move some maintainers from active to Emeritus Mar 24, 2026

peterzhuamazon previously approved these changes Mar 24, 2026

View reviewed changes

peterzhuamazon marked this pull request as ready for review March 24, 2026 18:54

peterzhuamazon requested review from RyanL1997, Swiddis, acarbonetto, ahkcs, anirudha, dai-chen, joshuali925, mengweieric, noCharger, penghuo, ps48, qianheng-aws, vamsimanohar, ykmr1224 and yuancu as code owners March 24, 2026 18:54

ahkcs previously approved these changes Mar 24, 2026

View reviewed changes

Swiddis previously approved these changes Mar 24, 2026

View reviewed changes

Merge branch 'main' into pr/to_emeritus

2683713

Signed-off-by: Simeon Widdis <sawiddis@gmail.com>

Swiddis dismissed stale reviews from ahkcs, peterzhuamazon, and themself via 2683713 March 24, 2026 19:27

Swiddis requested a review from songkant-aws as a code owner March 24, 2026 19:27

Swiddis previously approved these changes Mar 24, 2026

View reviewed changes

Swiddis requested review from ahkcs and peterzhuamazon March 24, 2026 19:28

Fix formatting in MAINTAINERS.md

1ed4502

Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com>

Swiddis dismissed their stale review via 1ed4502 March 24, 2026 19:30

Swiddis approved these changes Mar 24, 2026

View reviewed changes

ahkcs approved these changes Mar 24, 2026

View reviewed changes

Swiddis merged commit bebb75b into opensearch-project:main Mar 24, 2026
37 checks passed

github-actions bot mentioned this pull request Apr 4, 2026

[AUTO] Add release notes for 3.6.0 #5314

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move some maintainers from active to Emeritus#5260

Move some maintainers from active to Emeritus#5260
Swiddis merged 5 commits intoopensearch-project:mainfrom
LantaoJin:pr/to_emeritus

LantaoJin commented Mar 24, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 24, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 24, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

LantaoJin commented Mar 24, 2026

Uh oh!

Swiddis left a comment •

edited

Loading

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

LantaoJin commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Check List

Uh oh!

github-actions bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Reviewer Guide 🔍

(Review updated until commit 1ed4502)

Uh oh!

github-actions bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Code Suggestions ✨

Previous suggestions

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

LantaoJin commented Mar 24, 2026

Uh oh!

Swiddis left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LantaoJin commented Mar 24, 2026 •

edited

Loading

github-actions bot commented Mar 24, 2026 •

edited

Loading

(Review updated until commit `1ed4502`)

github-actions bot commented Mar 24, 2026 •

edited

Loading

Swiddis left a comment •

edited

Loading