Skip to content

Fix the flaky yamlRestTest caused by order of sample_logs#5119

Merged
yuancu merged 1 commit intoopensearch-project:mainfrom
LantaoJin:pr/issues/5118
Feb 6, 2026
Merged

Fix the flaky yamlRestTest caused by order of sample_logs#5119
yuancu merged 1 commit intoopensearch-project:mainfrom
LantaoJin:pr/issues/5118

Conversation

@LantaoJin
Copy link
Copy Markdown
Member

@LantaoJin LantaoJin commented Feb 6, 2026 •
edited
Loading

Description

Patterns with specified max_sample_count should return correct result is flaky

Related Issues

Resolves #5118

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • New PPL command checklist all confirmed.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@LantaoJin
Fix the flaky yamlRestTest caused by order of sample_logs
6c5627a 
Signed-off-by: Lantao Jin <ltjin@amazon.com>
@LantaoJin LantaoJin added flaky-test Flaky build or test issue testing Related to improving software testing labels Feb 6, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 6, 2026 •
edited
Loading

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated integration test setup to explicitly configure index creation and shard/replica settings before data indexing.

Walkthrough

A test configuration file is updated to add an explicit index creation step with specific shard and replica settings in the setup section, preparing the test environment before bulk document indexing.

Changes

Cohort / File(s) Summary
Test Setup Configuration
integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/4866.yml		 Added indices.create operation in setup section to create hdfs_logs index with explicit shard and replica settings before bulk indexing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly refers to fixing flaky yamlRestTest caused by order of sample_logs, which directly matches the changeset that adds index creation to ensure deterministic ordering.
Description check ✅ Passed The description references the flaky test and issue #5118, which directly relates to the non-deterministic ordering problem addressed by the changeset.
Linked Issues check ✅ Passed The PR adds index creation with explicit shard/replica settings to ensure deterministic test execution, directly addressing issue #5118's root cause of non-deterministic sample_logs ordering.
Out of Scope Changes check ✅ Passed The single change adds necessary index setup configuration to the test file, which is directly in scope for fixing the flaky test described in issue #5118.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@LantaoJin LantaoJin marked this pull request as ready for review February 6, 2026 04:41
@yuancu yuancu merged commit 7313be5 into opensearch-project:main Feb 6, 2026
43 of 44 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2026
@github-actions
Fix the flaky yamlRestTest caused by order of sample_logs (#5119)
ba2e803 
Signed-off-by: Lantao Jin <ltjin@amazon.com>
(cherry picked from commit 7313be5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 6, 2026
Merged
LantaoJin pushed a commit that referenced this pull request Feb 9, 2026
@opensearch-trigger-bot @github-actions
Fix the flaky yamlRestTest caused by order of sample_logs (#5119) (#5123
8f858fd 
)

(cherry picked from commit 7313be5)

Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
asifabashar pushed a commit to asifabashar/sql that referenced this pull request Feb 10, 2026
@LantaoJin @asifabashar
Fix the flaky yamlRestTest caused by order of sample_logs (opensearch…
f920bc4 
…-project#5119)

Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin added a commit that referenced this pull request Feb 11, 2026
@LantaoJin @songkant-aws
Sync with main branch (#5137)
bfd31e0 
* [BugFix] Fix the bug when boolean comparison condition is simplifed to field (#5071)

* Fix the bug when boolean comparison condition is simplifed to field

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Update tests and cover more cases

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Correct the logic of not boolean comparison

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Add missing IS_FALSE RexNode translation

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Remove unnecessary boolean expression conversion

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Fix spotless check

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Refactor PredicateAnalyzer logic a bit

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Add more strict not expression match for field

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Fix spotless check and flaky test

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Cover more cases for IS_FALSE, IS_NOT_TRUE, IS_NOT_FALSE

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Complement the truth tests for expressions

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Fix logic

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Fix spotless check

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Add additional boolean filter only pushdown explain test cases

Signed-off-by: Songkan Tang <songkant@amazon.com>

---------

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Fix the flaky yamlRestTest caused by order of sample_logs (#5119)

Signed-off-by: Lantao Jin <ltjin@amazon.com>

* LAST/FIRST/TAKE aggregation should support TEXT type and Scripts (#5091)

* Use fetchSource API instead of fetchFields for LAST/FIRST/TAKE aggregation

Signed-off-by: Lantao Jin <ltjin@amazon.com>

* Fix IT

Signed-off-by: Lantao Jin <ltjin@amazon.com>

* Merge remote-tracking branch 'upstream/main' into issues/5086

* LAST/FIRST/TAKE aggregation should support TEXT type and Scripts

Signed-off-by: Lantao Jin <ltjin@amazon.com>

* Add more tests

Signed-off-by: Lantao Jin <ltjin@amazon.com>

* Merge remote-tracking branch 'upstream/main' into issues/5086

* Fix IT

Signed-off-by: Lantao Jin <ltjin@amazon.com>

* Fix IT

Signed-off-by: Lantao Jin <ltjin@amazon.com>

* fix explain text

Signed-off-by: Lantao Jin <ltjin@amazon.com>

---------

Signed-off-by: Songkan Tang <songkant@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: Songkan Tang <songkant@amazon.com>
LantaoJin added a commit to LantaoJin/search-plugins-sql that referenced this pull request Feb 12, 2026
@LantaoJin
Fix the flaky yamlRestTest caused by order of sample_logs (opensearch…
70884b1 
…-project#5119)

Signed-off-by: Lantao Jin <ltjin@amazon.com>
@github-actions github-actions bot mentioned this pull request Apr 4, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuancu yuancu yuancu approved these changes

@qianheng-aws qianheng-aws qianheng-aws approved these changes

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm

@derek-ho derek-ho Awaiting requested review from derek-ho

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar vamsimanohar is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG

@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 is a code owner

@noCharger noCharger Awaiting requested review from noCharger noCharger is a code owner

@RyanL1997 RyanL1997 Awaiting requested review from RyanL1997 RyanL1997 is a code owner

Assignees

No one assigned

Labels

backport 2.19-dev flaky-test Flaky build or test issue testing Related to improving software testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] The sample_logs array in the patterns command results had non-deterministic ordering

3 participants

@LantaoJin @yuancu @qianheng-aws