Remove doPrivileged call in Calcite script execution#4900
Merged
penghuo merged 1 commit intoopensearch-project:mainfrom Dec 4, 2025
Merged
Remove doPrivileged call in Calcite script execution#4900penghuo merged 1 commit intoopensearch-project:mainfrom
penghuo merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Collaborator
|
Grreat! I remember somehow 2.19 still needs it. But it was removed in OpenSearch since 3.x version. |
penghuo
approved these changes
Dec 4, 2025
dai-chen
approved these changes
Dec 4, 2025
Collaborator
dai-chen
left a comment
There was a problem hiding this comment.
Thanks for the changes! If I recall right, this is mostly for action whitelisted in plugin-security.policy?
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Seems to delete a major perf bottleneck: we create an access controller context for every individual document we process in a script, which involves a lot of stack trace traversal and locking for accessing that context. Curious what the breakage is if I just delete this controller step, since it passes tests locally. At least for the query I was interested in, it reduced the runtime from 70 seconds (2mil documents) to 4.
Better approach if we need it: move the privilege step to outside the core script loop.
Measured from slow query (big5 dataset):
Before (70s/query):
After (4s/query):
Related Issues
N/A
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.