Grouping key field type can only be overwritten when the ExprCoreTypes are different#4850
Merged
yuancu merged 1 commit intoopensearch-project:mainfrom Nov 24, 2025
Merged
Conversation
… are different Signed-off-by: Lantao Jin <ltjin@amazon.com>
qianheng-aws
approved these changes
Nov 24, 2025
yuancu
approved these changes
Nov 24, 2025
asifabashar
pushed a commit
to asifabashar/sql
that referenced
this pull request
Dec 10, 2025
… are different (opensearch-project#4850) Signed-off-by: Lantao Jin <ltjin@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This bug introduced by #4500 by overwriting a new OpenSearchDateType which the custom formats are missing.
How to fix:
We only overwrite the group field' type when their
ExprCoreTypes are different.Related Issues
Resolves #4845
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.