Update syntax: like(string, PATTERN[, case_sensitive])#4837
Merged
qianheng-aws merged 11 commits intoopensearch-project:mainfrom Nov 25, 2025
Merged
Update syntax: like(string, PATTERN[, case_sensitive])#4837qianheng-aws merged 11 commits intoopensearch-project:mainfrom
qianheng-aws merged 11 commits intoopensearch-project:mainfrom
Conversation
…tive Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
like function to case-sensitive and add ilike for case-insensivelike function to case-sensitive and add ilike for case-insensitive
Signed-off-by: Lantao Jin <ltjin@amazon.com>
like function to case-sensitive and add ilike for case-insensitiveSigned-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
yuancu
previously approved these changes
Nov 24, 2025
yuancu
approved these changes
Nov 25, 2025
qianheng-aws
approved these changes
Nov 25, 2025
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4837-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 164c3f08754ac6b945c7dfa9a0bf8041e1a6671a
# Push it to GitHub
git push --set-upstream origin backport/backport-4837-to-2.19-dev
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-devThen, create a pull request where the |
LantaoJin
added a commit
to LantaoJin/search-plugins-sql
that referenced
this pull request
Nov 26, 2025
…oject#4837) * Change like function to case-sensitive and add ilike for case-insensitive Signed-off-by: Lantao Jin <ltjin@amazon.com> * change plan in clickbench Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix ut Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix UT Signed-off-by: Lantao Jin <ltjin@amazon.com> * Update syntax: like(string, PATTERN[, case_sensitive]) Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix IT Signed-off-by: Lantao Jin <ltjin@amazon.com> * Fix IT Signed-off-by: Lantao Jin <ltjin@amazon.com> * revert import merging Signed-off-by: Lantao Jin <ltjin@amazon.com> * support like(string, PATTERN, bool) in v2 Signed-off-by: Lantao Jin <ltjin@amazon.com> * dedup ut Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com> (cherry picked from commit 164c3f0)
LantaoJin
added a commit
that referenced
this pull request
Nov 26, 2025
* Change like function to case-sensitive and add ilike for case-insensitive * change plan in clickbench * fix ut * fix UT * Update syntax: like(string, PATTERN[, case_sensitive]) * fix IT * Fix IT * revert import merging * support like(string, PATTERN, bool) in v2 * dedup ut --------- (cherry picked from commit 164c3f0) Signed-off-by: Lantao Jin <ltjin@amazon.com>
asifabashar
pushed a commit
to asifabashar/sql
that referenced
this pull request
Dec 10, 2025
…oject#4837) * Change like function to case-sensitive and add ilike for case-insensitive Signed-off-by: Lantao Jin <ltjin@amazon.com> * change plan in clickbench Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix ut Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix UT Signed-off-by: Lantao Jin <ltjin@amazon.com> * Update syntax: like(string, PATTERN[, case_sensitive]) Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix IT Signed-off-by: Lantao Jin <ltjin@amazon.com> * Fix IT Signed-off-by: Lantao Jin <ltjin@amazon.com> * revert import merging Signed-off-by: Lantao Jin <ltjin@amazon.com> * support like(string, PATTERN, bool) in v2 Signed-off-by: Lantao Jin <ltjin@amazon.com> * dedup ut Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
likefunction.likefunction and add a new case-sensitiveilikefunction.LIKE
Usage: like(string, PATTERN[, case_sensitive]) return true if the string match the PATTERN.
case_sensitiveis optional. When set totrue, PATTERN is case-sensitive. Default: Determined byplugins.ppl.syntax.legacy.preferred.plugins.ppl.syntax.legacy.preferred=true,case_sensitivedefaults tofalseplugins.ppl.syntax.legacy.preferred=false,case_sensitivedefaults totruePlan:
where like(firstname, '%mbe%', true)(PPL)⬇️
LogicalFilter(condition=[LIKE($1, '%mbe%', '\')])(RelNode)⬇️
WHERE firstname LIKE '%mbe%' ESCAPE '\'(SparkSQL)ILIKE
Usage: ilike(string, PATTERN) return true if the string match the PATTERN, PATTERN is case-insensitive.
Plan
where ilike(firstname, '%mbe%')orwhere like(firstname, '%mbe%', false)(PPL)⬇️
LogicalFilter(condition=[ILIKE($1, '%mbe%', '\')])(RelNode)⬇️
WHERE firstname ILIKE '%mbe%' ESCAPE '\'(SparkSQL)Related Issues
Resolves #4835
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.