Fix search anoymizer only#4783
Merged
yuancu merged 12 commits intoopensearch-project:mainfrom Nov 21, 2025
Merged
Conversation
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
yuancu
reviewed
Nov 17, 2025
ppl/src/test/java/org/opensearch/sql/ppl/utils/PPLQueryDataAnonymizerTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: xinyual <xinyual@amazon.com>
yuancu
previously approved these changes
Nov 18, 2025
Signed-off-by: xinyual <xinyual@amazon.com>
yuancu
previously approved these changes
Nov 18, 2025
LantaoJin
reviewed
Nov 19, 2025
Comment on lines
+909
to
+910
| "source=table (identifier >= *** OR identifier <= ***)", | ||
| anonymize("search source=t earliest='2012-12-10 15:00:00' or latest=now")); |
Member
There was a problem hiding this comment.
It's odd that the = anonymized to >= and <=. It changes the semantic IMO.
Member
There was a problem hiding this comment.
Change to such as time_identifier?
For meta fields such as _id, _doc etc, how about anonymize to meta_identifier?
Contributor
Author
There was a problem hiding this comment.
Already add time_identifier with meta_identifier. Please check it.
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
LantaoJin
approved these changes
Nov 21, 2025
yuancu
approved these changes
Nov 21, 2025
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4783-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a8069d18a360396594d4c47e672babc56a21a2fa
# Push it to GitHub
git push --set-upstream origin backport/backport-4783-to-2.19-dev
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-devThen, create a pull request where the |
8 tasks
asifabashar
pushed a commit
to asifabashar/sql
that referenced
this pull request
Dec 10, 2025
* fix anoymizer for search command Signed-off-by: xinyual <xinyual@amazon.com> * pushdown match when only one equal in search command Signed-off-by: xinyual <xinyual@amazon.com> * fix regex case Signed-off-by: xinyual <xinyual@amazon.com> * fix UT Signed-off-by: xinyual <xinyual@amazon.com> * fix UT Signed-off-by: xinyual <xinyual@amazon.com> * revert match change Signed-off-by: xinyual <xinyual@amazon.com> * fix UT by ignore the expression Signed-off-by: xinyual <xinyual@amazon.com> * remove useless change and resolve comment Signed-off-by: xinyual <xinyual@amazon.com> * remove useless change and resolve comment Signed-off-by: xinyual <xinyual@amazon.com> * add test cases for metadata and timestamp identifier Signed-off-by: xinyual <xinyual@amazon.com> * change name Signed-off-by: xinyual <xinyual@amazon.com> --------- Signed-off-by: xinyual <xinyual@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The pr fix the PPLQueryDataAnonymizer's bug about search command.
Related Issues
Resolves #4290
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.