Skip to content

Update big5 ppl queries and check plans#4668

Merged
qianheng-aws merged 4 commits intoopensearch-project:mainfrom
LantaoJin:pr/issues/4667
Oct 28, 2025
Merged

Update big5 ppl queries and check plans#4668
qianheng-aws merged 4 commits intoopensearch-project:mainfrom
LantaoJin:pr/issues/4667

Conversation

@LantaoJin
Copy link
Copy Markdown
Member

@LantaoJin LantaoJin commented Oct 26, 2025 •
edited
Loading

Description

Update big5 ppl queries:

Related Issues

Resolves #4667

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • New PPL command checklist all confirmed.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@LantaoJin
Update big5 ppl queries
0659247 
Signed-off-by: Lantao Jin <ltjin@amazon.com>
@LantaoJin LantaoJin added bug Something isn't working testing Related to improving software testing labels Oct 26, 2025
@LantaoJin LantaoJin marked this pull request as ready for review October 26, 2025 09:03
@LantaoJin
Copy link
Copy Markdown
Member Author

LantaoJin commented Oct 26, 2025

@noCharger please view this update and we might need to update our benchmark as well.

@LantaoJin
Add explain check for big5 queries
ad572cf 
Signed-off-by: Lantao Jin <ltjin@amazon.com>
@LantaoJin
Merge remote-tracking branch 'upstream/main' into issues/4667
0a1969c
@LantaoJin
update to latest code base
412f7d1 
Signed-off-by: Lantao Jin <ltjin@amazon.com>
@LantaoJin LantaoJin changed the title Update big5 ppl queries Update big5 ppl queries and check plans Oct 26, 2025
@penghuo
Copy link
Copy Markdown
Collaborator

penghuo commented Oct 27, 2025 •
edited
Loading

for queries defined big5/queries/optimized/, we should updated in opensearch-benchmark repo?

penghuo
penghuo reviewed Oct 28, 2025
View reviewed changes
integ-test/src/test/java/org/opensearch/sql/calcite/big5/PPLBig5IT.java
protected String loadExpectedQuery(String fileName) throws IOException {
if (isCalciteEnabled()) {
try {
return loadFromFile("big5/queries/optimized/" + fileName);
Copy link
Copy Markdown
Collaborator

@penghuo penghuo Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have optimized folder? it required calcite enable?
IMO, PPL big5 query should be optimized queries.

Copy link
Copy Markdown
Member Author

@LantaoJin LantaoJin Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That because 1. bucket_nullable argument, 2. bin command

penghuo
penghuo approved these changes Oct 28, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport to 2.19-dev.

@LantaoJin
Copy link
Copy Markdown
Member Author

LantaoJin commented Oct 28, 2025 •
edited
Loading

for queries defined big5/queries/optimized/, we should updated in opensearch-benchmark repo?

Yes. cc @noCharger and @xinyual

@qianheng-aws qianheng-aws merged commit 0f45382 into opensearch-project:main Oct 28, 2025
55 of 56 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 28, 2025
@github-actions
Update big5 ppl queries and check plans (#4668)
45ebc39 
* Update big5 ppl queries

Signed-off-by: Lantao Jin <ltjin@amazon.com>

* Add explain check for big5 queries

Signed-off-by: Lantao Jin <ltjin@amazon.com>

* update to latest code base

Signed-off-by: Lantao Jin <ltjin@amazon.com>

---------

Signed-off-by: Lantao Jin <ltjin@amazon.com>
(cherry picked from commit 0f45382)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 28, 2025
Merged
@LantaoJin LantaoJin deleted the pr/issues/4667 branch October 28, 2025 05:59
LantaoJin pushed a commit that referenced this pull request Oct 28, 2025
@opensearch-trigger-bot @github-actions
Update big5 ppl queries and check plans (#4668) (#4680)
9a52ed9 
* Update big5 ppl queries



* Add explain check for big5 queries



* update to latest code base



---------


(cherry picked from commit 0f45382)

Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
asifabashar added a commit to asifabashar/sql that referenced this pull request Oct 28, 2025
@asifabashar
Merge branch 'default-main'
e7775d3 
* default-main: (34 commits)
  Enhance dynamic source clause to support only metadata filters (opensearch-project#4554)
  Make nested alias type support referring to outer context (opensearch-project#4673)
  Update big5 ppl queries and check plans (opensearch-project#4668)
  Support push down sort after limit (opensearch-project#4657)
  Use table scan rowType in filter pushdown could fix rename issue (opensearch-project#4670)
  Fix: Support Alias Fields in MIN, MAX, FIRST, LAST, and TAKE Aggregations (opensearch-project#4621)
  Fix bin nested fields issue (opensearch-project#4606)
  Add `per_minute`, `per_hour`, `per_day` function support (opensearch-project#4531)
  Pushdown sort aggregate metrics (opensearch-project#4603)
  Followup: Change ComparableLinkedHashMap to compare Key than Value (opensearch-project#4648)
  Mitigate the CI failure caused by 500 Internal Server Error (opensearch-project#4646)
  Allow renaming group-by fields to existing field names (opensearch-project#4586)
  Publish internal modules separately for downstream reuse (opensearch-project#4484)
  Revert "Update grammar files and developer guide (opensearch-project#4301)" (opensearch-project#4643)
  Support Automatic Type Conversion for REX/SPATH/PARSE Command Extractions (opensearch-project#4599)
  Replace all dots in fields of table scan's PhysType (opensearch-project#4633)
  Return comparable LinkedHashMap in `valueForCalcite()` of ExprTupleValue (opensearch-project#4629)
  Refactor JsonExtractAllFunctionIT and MapConcatFunctionIT (opensearch-project#4623)
  Pushdown case function in aggregations as range queries (opensearch-project#4400)
  Update GEOIP function to support IP types as input (opensearch-project#4613)
  ...

# Conflicts:
#	docs/user/ppl/functions/conversion.rst
asifabashar added a commit to asifabashar/sql that referenced this pull request Oct 28, 2025
@asifabashar
Merge branch 'default-main'
42d705a 
* default-main: (34 commits)
  Enhance dynamic source clause to support only metadata filters (opensearch-project#4554)
  Make nested alias type support referring to outer context (opensearch-project#4673)
  Update big5 ppl queries and check plans (opensearch-project#4668)
  Support push down sort after limit (opensearch-project#4657)
  Use table scan rowType in filter pushdown could fix rename issue (opensearch-project#4670)
  Fix: Support Alias Fields in MIN, MAX, FIRST, LAST, and TAKE Aggregations (opensearch-project#4621)
  Fix bin nested fields issue (opensearch-project#4606)
  Add `per_minute`, `per_hour`, `per_day` function support (opensearch-project#4531)
  Pushdown sort aggregate metrics (opensearch-project#4603)
  Followup: Change ComparableLinkedHashMap to compare Key than Value (opensearch-project#4648)
  Mitigate the CI failure caused by 500 Internal Server Error (opensearch-project#4646)
  Allow renaming group-by fields to existing field names (opensearch-project#4586)
  Publish internal modules separately for downstream reuse (opensearch-project#4484)
  Revert "Update grammar files and developer guide (opensearch-project#4301)" (opensearch-project#4643)
  Support Automatic Type Conversion for REX/SPATH/PARSE Command Extractions (opensearch-project#4599)
  Replace all dots in fields of table scan's PhysType (opensearch-project#4633)
  Return comparable LinkedHashMap in `valueForCalcite()` of ExprTupleValue (opensearch-project#4629)
  Refactor JsonExtractAllFunctionIT and MapConcatFunctionIT (opensearch-project#4623)
  Pushdown case function in aggregations as range queries (opensearch-project#4400)
  Update GEOIP function to support IP types as input (opensearch-project#4613)
  ...

Signed-off-by: Asif Bashar <asif.bashar@gmail.com>
@RyanL1997 RyanL1997 mentioned this pull request Oct 28, 2025
Closed
2 tasks
expani pushed a commit to vinaykpud/sql that referenced this pull request Nov 4, 2025
@LantaoJin @expani
Update big5 ppl queries and check plans (opensearch-project#4668)
ea1ad6a 
* Update big5 ppl queries

Signed-off-by: Lantao Jin <ltjin@amazon.com>

* Add explain check for big5 queries

Signed-off-by: Lantao Jin <ltjin@amazon.com>

* update to latest code base

Signed-off-by: Lantao Jin <ltjin@amazon.com>

---------

Signed-off-by: Lantao Jin <ltjin@amazon.com>
@noCharger noCharger mentioned this pull request Nov 5, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@penghuo penghuo penghuo approved these changes

@yuancu yuancu yuancu approved these changes

@qianheng-aws qianheng-aws qianheng-aws approved these changes

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm

@derek-ho derek-ho Awaiting requested review from derek-ho

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar vamsimanohar is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG

@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 is a code owner

@noCharger noCharger Awaiting requested review from noCharger noCharger is a code owner

@RyanL1997 RyanL1997 Awaiting requested review from RyanL1997 RyanL1997 is a code owner

Assignees

No one assigned

Labels

backport 2.19-dev bug Something isn't working testing Related to improving software testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Some big5 PPL queries are out of date in v3

4 participants

@LantaoJin @penghuo @yuancu @qianheng-aws