Skip to content

Optimize pushdown script size with necessary fields per expression#4615

Merged
yuancu merged 3 commits intoopensearch-project:mainfrom
songkant-aws:wide-schema-script-optimization
Oct 21, 2025
Merged

Optimize pushdown script size with necessary fields per expression#4615
yuancu merged 3 commits intoopensearch-project:mainfrom
songkant-aws:wide-schema-script-optimization

Conversation

@songkant-aws
Copy link
Copy Markdown
Collaborator

@songkant-aws songkant-aws commented Oct 21, 2025

Description

This optimization aims to resolve #4547, #4597. With necessary fields to be serialized per expression, script size will be minimized by rewriting expression input indices and pruning field types. It will mitigate the issue of exceeding script size limit for queries over wide schema indices.

Related Issues

Resolves #4547 , resolves #4597

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • New PPL command checklist all confirmed.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Songkan Tang <songkant@amazon.com>
Signed-off-by: Songkan Tang <songkant@amazon.com>
Signed-off-by: Songkan Tang <songkant@amazon.com>
@yuancu yuancu merged commit e76754c into opensearch-project:main Oct 21, 2025
53 of 55 checks passed
@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

The backport to 2.19-dev failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4615-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e76754c0ab2dedfda9c5f7271e84ff5ac0aa8dc3
# Push it to GitHub
git push --set-upstream origin backport/backport-4615-to-2.19-dev
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-dev

Then, create a pull request where the base branch is 2.19-dev and the compare/head branch is backport/backport-4615-to-2.19-dev.

songkant-aws added a commit to songkant-aws/sql that referenced this pull request Oct 22, 2025
…pensearch-project#4615)

* Optimize pushdown script size with necessary fields per expression

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Revert unexpected change for CalciteNoPushdownIT

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Fix UT

Signed-off-by: Songkan Tang <songkant@amazon.com>

---------

Signed-off-by: Songkan Tang <songkant@amazon.com>
songkant-aws added a commit to songkant-aws/sql that referenced this pull request Oct 22, 2025
…pensearch-project#4615)

* Optimize pushdown script size with necessary fields per expression

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Revert unexpected change for CalciteNoPushdownIT

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Fix UT

Signed-off-by: Songkan Tang <songkant@amazon.com>

---------

Signed-off-by: Songkan Tang <songkant@amazon.com>
yuancu pushed a commit that referenced this pull request Oct 22, 2025
…ds per expression (#4615) (#4628)

* Optimize pushdown script size with necessary fields per expression (#4615)

* Optimize pushdown script size with necessary fields per expression

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Revert unexpected change for CalciteNoPushdownIT

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Fix UT

Signed-off-by: Songkan Tang <songkant@amazon.com>

---------

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Resolve compilation issue

Signed-off-by: Songkan Tang <songkant@amazon.com>

---------

Signed-off-by: Songkan Tang <songkant@amazon.com>
@songkant-aws songkant-aws deleted the wide-schema-script-optimization branch October 24, 2025 07:30
@LantaoJin LantaoJin added the backport-manually Filed a PR to backport manually. label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.19-dev backport-failed backport-manually Filed a PR to backport manually. bug Something isn't working

Projects

None yet

4 participants