Support Grok command in Calcite engine#3678
Merged
penghuo merged 7 commits intoopensearch-project:mainfrom Jun 4, 2025
Merged
Conversation
Signed-off-by: Songkan Tang <songkant@amazon.com>
Signed-off-by: Songkan Tang <songkant@amazon.com>
Signed-off-by: Songkan Tang <songkant@amazon.com>
Signed-off-by: Songkan Tang <songkant@amazon.com>
dai-chen
reviewed
May 27, 2025
core/src/main/java/org/opensearch/sql/expression/function/udf/GrokFunction.java
Show resolved
Hide resolved
Signed-off-by: Songkan Tang <songkant@amazon.com>
Signed-off-by: Songkan Tang <songkant@amazon.com>
LantaoJin
approved these changes
May 30, 2025
Member
|
CI failure is not related. |
dai-chen
approved these changes
Jun 4, 2025
Collaborator
dai-chen
left a comment
There was a problem hiding this comment.
Thanks for the changes!
| registerOperator(IF, SqlStdOperatorTable.CASE); | ||
| registerOperator(IFNULL, SqlStdOperatorTable.COALESCE); | ||
| registerOperator(COALESCE, SqlStdOperatorTable.COALESCE); | ||
| registerOperator(INTERNAL_ITEM, SqlStdOperatorTable.ITEM); |
Collaborator
There was a problem hiding this comment.
Calcite ITEM function is public right? Why we need another internal one?
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
* Support Grok command in Calcite engine Signed-off-by: Songkan Tang <songkant@amazon.com> * Register SqlStdOperatorTable.ITEM into PPLFuncImpTable Signed-off-by: Songkan Tang <songkant@amazon.com> * Fix case function ITs caused by weblogs index data change Signed-off-by: Songkan Tang <songkant@amazon.com> * Enforce Locale attempt to fix flaky grok compilation Signed-off-by: Songkan Tang <songkant@amazon.com> * Fix checkstyle Signed-off-by: Songkan Tang <songkant@amazon.com> * Add anonymizer test for grok command Signed-off-by: Songkan Tang <songkant@amazon.com> --------- Signed-off-by: Songkan Tang <songkant@amazon.com> Signed-off-by: xinyual <xinyual@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support Grok command in Calcite engine
Related Issues
Resolves #3677
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.