[Spotless] Applying Google Code Format for core/src/main files #2#1931
Merged
Yury-Fridlyand merged 11 commits intoopensearch-project:mainfrom Aug 9, 2023
Merged
Conversation
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
[Spotless] Applying Google Code Format for core/src/main files #2
6 tasks
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Codecov Report
@@ Coverage Diff @@
## main #1931 +/- ##
============================================
+ Coverage 97.42% 97.51% +0.08%
- Complexity 4646 4658 +12
============================================
Files 408 408
Lines 11549 11934 +385
Branches 838 834 -4
============================================
+ Hits 11252 11637 +385
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
GumpacG
previously approved these changes
Aug 4, 2023
acarbonetto
previously approved these changes
Aug 4, 2023
Yury-Fridlyand
previously approved these changes
Aug 5, 2023
Collaborator
Yury-Fridlyand
left a comment
There was a problem hiding this comment.
Minor polishing is needed
core/src/main/java/org/opensearch/sql/executor/ExecutionEngine.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/executor/QueryManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/executor/QueryService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/executor/pagination/CanPaginateVisitor.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/text/TextFunction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
7f85b3b
6 tasks
GumpacG
previously approved these changes
Aug 8, 2023
6 tasks
Yury-Fridlyand
previously approved these changes
Aug 8, 2023
core/src/main/java/org/opensearch/sql/executor/pagination/CanPaginateVisitor.java
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/datetime/DateTimeFormatterUtil.java
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/datetime/DateTimeFunction.java
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
dc7998a
Yury-Fridlyand
previously approved these changes
Aug 9, 2023
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
GumpacG
previously approved these changes
Aug 9, 2023
Collaborator
Yury-Fridlyand
left a comment
There was a problem hiding this comment.
LGFM, but SL blames some of your recent changes.
Is it possible to export SL output to a file?
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Contributor
Author
Into artifacts? |
Contributor
Author
|
Only failing BWC and codecov. @Yury-Fridlyand @GumpacG now. Good to merge? |
GumpacG
approved these changes
Aug 9, 2023
Yury-Fridlyand
approved these changes
Aug 9, 2023
6 tasks
MitchellGale
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 14, 2023
…ensearch-project#1931) * Applied spotless changes to `core/stc/main/.../expression` and more. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Applied all spotless for PR 2 for GJF Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Apply spotless to fix custom fixes. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Remove unused <br> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * ignoring core checkstyle failures. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * addressed PR comments. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Addressing PR 2 comments. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Ran spotless apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 18, 2023
…ensearch-project#1931) * Applied spotless changes to `core/stc/main/.../expression` and more. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Applied all spotless for PR 2 for GJF Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Apply spotless to fix custom fixes. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Remove unused <br> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * ignoring core checkstyle failures. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * addressed PR comments. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Addressing PR 2 comments. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Ran spotless apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
6 tasks
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Aug 22, 2023
…in files #2 #1931 (#1993) * [Spotless] Applying Google Code Format for core/src/main files #2 (#1931) * Applied spotless changes to `core/stc/main/.../expression` and more. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Applied all spotless for PR 2 for GJF Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Apply spotless to fix custom fixes. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Remove unused <br> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * ignoring core checkstyle failures. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * addressed PR comments. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Addressing PR 2 comments. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Ran spotless apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * spotless apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * address pr comments Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR applies Spotless on Java code for:
core/src/main/java/org/opensearch/sql/exceptioncore/src/main/java/org/opensearch/sql/executorcore/src/main/java/org/opensearch/sql/expressioncore/src/main/java/org/opensearch/sql/monitorIssues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.