Fix core refactor: StreamIO from common to core.common (#296)#1869
Merged
acarbonetto merged 1 commit intoopensearch-project:mainfrom Jul 14, 2023
Merged
Conversation
* Fix core refactor: StreamIO from common to core.common Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Fix core refactor: StreamIO from common to core.common Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
372ef91 to
0a2f6d7
Compare
Codecov Report
@@ Coverage Diff @@
## main #1869 +/- ##
=========================================
Coverage 97.39% 97.39%
Complexity 4602 4602
=========================================
Files 401 401
Lines 11386 11386
Branches 843 843
=========================================
Hits 11089 11089
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Yury-Fridlyand
approved these changes
Jul 14, 2023
Collaborator
Yury-Fridlyand
left a comment
There was a problem hiding this comment.
Ignore BWC failures
MitchellGale
approved these changes
Jul 14, 2023
GumpacG
approved these changes
Jul 14, 2023
matthewryanwells
approved these changes
Jul 14, 2023
matthewryanwells
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 14, 2023
…arch-project#1869) * Fix core refactor: StreamIO from common to core.common * Fix core refactor: StreamIO from common to core.common --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 20, 2023
…arch-project#1869) * Fix core refactor: StreamIO from common to core.common * Fix core refactor: StreamIO from common to core.common --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 20, 2023
…arch-project#1869) * Fix core refactor: StreamIO from common to core.common * Fix core refactor: StreamIO from common to core.common --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
vamsimanohar
added a commit
that referenced
this pull request
Jul 26, 2023
…#296) (#1891) * Fix core refactor: StreamIO from common to core.common (#296) (#1869) * Fix core refactor: StreamIO from common to core.common * Fix core refactor: StreamIO from common to core.common --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com> (cherry picked from commit dae5a85) * Bump Version and Fix import error Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Co-authored-by: Andrew Carbonetto <andrewc@bitquilltech.com> Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 28, 2023
…arch-project#1869) * Fix core refactor: StreamIO from common to core.common * Fix core refactor: StreamIO from common to core.common --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix compilation errors after opensearch-project/OpenSearch#8157.
Note: May need backport 2.x label.
In this PR it's only changing package name of core classes in import section
Issues Resolved
Fixes changes from opensearch-project/ml-commons#1122
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.