Skip to content

update codeowners and maintainers#1579

Merged
MaxKsyunz merged 1 commit intoopensearch-project:mainfrom
derek-ho:codeowners
Apr 25, 2023
Merged

update codeowners and maintainers#1579
MaxKsyunz merged 1 commit intoopensearch-project:mainfrom
derek-ho:codeowners

Conversation

@derek-ho
Copy link
Copy Markdown
Contributor

@derek-ho derek-ho commented Apr 25, 2023

Description

Baseline repo maintainers and codeowners

Issues Resolved

fix: #1337

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <dxho@amazon.com>
@MaxKsyunz MaxKsyunz merged commit edcd6a9 into opensearch-project:main Apr 25, 2023
@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1579-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 edcd6a9a846d04814bf66e3552a2f64319557f24
# Push it to GitHub
git push --set-upstream origin backport/backport-1579-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1579-to-2.x.

@MaxKsyunz
Copy link
Copy Markdown
Collaborator

@derek-ho This PR needs to be backported to 2.x so that the new code owners are treated as such in the 2.x branch.

Yury-Fridlyand pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Apr 25, 2023
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@bbarani
Copy link
Copy Markdown
Member

bbarani commented Apr 25, 2023

This PR should not be ideally merged until CODEOWNERS file turns green.

@bbarani
Copy link
Copy Markdown
Member

bbarani commented Apr 25, 2023

Its ready to merge. CODEOWNERS is green as I have added the maintainers.

@MaxKsyunz
Copy link
Copy Markdown
Collaborator

This PR should not be ideally merged until CODEOWNERS file turns green.
I didn't realize that, @bbarani. Will know for next time.

acarbonetto pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Apr 28, 2023
Signed-off-by: Derek Ho <dxho@amazon.com>
Yury-Fridlyand added a commit that referenced this pull request May 11, 2023
* Backport `CODEOWNERS` file from the main branch.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Backport MAINTAINERS file.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* update codeowners and maintainers (#1579)

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Derek Ho <dxho@amazon.com>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jun 12, 2023
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions

5 participants