Documentation and other papercuts for datasource api launch#1530
Conversation
cfdeb0d to
520d6d7
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1530 +/- ##
=========================================
Coverage 97.18% 97.18%
Complexity 4100 4100
=========================================
Files 371 371
Lines 10448 10448
Branches 703 703
=========================================
Hits 10154 10154
Misses 287 287
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
520d6d7 to
632e264
Compare
1846078 to
8ce367c
Compare
| */ | ||
| @BeforeClass | ||
| protected static void metricGenerationWait() throws InterruptedException { | ||
| Thread.sleep(20000); |
There was a problem hiding this comment.
This will extend CI run for 20 sec just for sleeping few times (few classes). Is it possible to do a conditional sleep? It is necessary to wait more than one time?
There was a problem hiding this comment.
I need to query prometheus in a loop till it generates metrics.
I can reduce this to 10sec.
There was a problem hiding this comment.
It will be great if you can, or consider this to follow-up update:
while (!isMetricsGenerated()) {
sleep(100);
}
There was a problem hiding this comment.
will follow up in the next release. Thanks.
8ce367c to
c5a94ca
Compare
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
c5a94ca to
f77f398
Compare
Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit fd1d7d8)
Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit fd1d7d8)
…ch-project#1530) Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Description
Issues Resolved
#1477
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.