[main]Changes in DataSourceService and DataSourceMetadataStorage interface#1408
Merged
vamsimanohar merged 2 commits intoopensearch-project:mainfrom Mar 8, 2023
Conversation
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
…taStorage Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1408 +/- ##
=========================================
Coverage 98.38% 98.38%
- Complexity 3694 3698 +4
=========================================
Files 343 343
Lines 9113 9121 +8
Branches 586 586
=========================================
+ Hits 8966 8974 +8
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
penghuo
approved these changes
Mar 8, 2023
dai-chen
approved these changes
Mar 8, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 8, 2023
…rface (#1408) * Added DataSourceMetadataStorage interface Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Added new interface methods in DataSourceService and DataSourceMetadataStorage Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit 98fb969)
matthewryanwells
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Mar 10, 2023
…rface (opensearch-project#1408) * Added DataSourceMetadataStorage interface Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Added new interface methods in DataSourceService and DataSourceMetadataStorage Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Signed-off-by: Matthew Wells <matthew.wells@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Definitions
usecases
code flow for each usecase.
Datasource bootstrapping during plugin startup [Internal usecase for storage engine creation]
Create datasource [REST API]
Get datasource along with storage engine and other artifacts [Internal use case only]
Get datasource [REST API]
Delete datasource [REST API]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.