Skip to content

[Backport main] Refactor AWSSigV4 auth to support different AWSCredentialProviders#1396

Merged
vamsimanohar merged 1 commit intomainfrom
backport/backport-1389-to-main
Mar 7, 2023
Merged

[Backport main] Refactor AWSSigV4 auth to support different AWSCredentialProviders#1396
vamsimanohar merged 1 commit intomainfrom
backport/backport-1389-to-main

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

Backport 8583fd1 from #1389

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 3, 2023 18:17
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 3, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.38%. Comparing base (cd95bc5) to head (e08fc51).
⚠️ Report is 1058 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1396   +/-   ##
=========================================
  Coverage     98.38%   98.38%           
- Complexity     3693     3694    +1     
=========================================
  Files           343      343           
  Lines          9107     9113    +6     
  Branches        585      586    +1     
=========================================
+ Hits           8960     8966    +6     
  Misses          142      142           
  Partials          5        5           
Flag Coverage Δ
sql-engine 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Yury-Fridlyand
Copy link
Copy Markdown
Collaborator

@opensearch-ci-bot rebase
Does it smart enough?

…1389)

* Refactor AWSSigV4 auth to support different AWSCredentialProviders

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Added unit tests for sts assume role credentials provider

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
(cherry picked from commit 8583fd1)
@vamsimanohar vamsimanohar force-pushed the backport/backport-1389-to-main branch from 26ba118 to e08fc51 Compare March 7, 2023 21:26
@vamsimanohar vamsimanohar merged commit ecea812 into main Mar 7, 2023
@github-actions github-actions bot deleted the backport/backport-1389-to-main branch March 7, 2023 22:46
matthewryanwells pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Mar 10, 2023
…pensearch-project#1389) (opensearch-project#1396)

* Refactor AWSSigV4 auth to support different AWSCredentialProviders

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Added unit tests for sts assume role credentials provider

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
(cherry picked from commit 8583fd1)

Co-authored-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants