Skip to content

Resolve table function based on StorageEngine provided function resolver#1354

Merged
penghuo merged 4 commits intoopensearch-project:mainfrom
penghuo:pr/spark/resolver
Mar 10, 2023
Merged

Resolve table function based on StorageEngine provided function resolver#1354
penghuo merged 4 commits intoopensearch-project:mainfrom
penghuo:pr/spark/resolver

Conversation

@penghuo
Copy link
Copy Markdown
Collaborator

@penghuo penghuo commented Feb 16, 2023 •
edited
Loading

Description

  1. Resolve table function based on StorageEngine provided function resolver.
  2. The JDBC datasource PR based on this PR.

Issues Resolved

#1331

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@penghuo penghuo self-assigned this Feb 16, 2023
penghuo
penghuo commented Feb 16, 2023
View reviewed changes
core/src/main/java/org/opensearch/sql/datasource/model/DataSourceType.java
PROMETHEUS,
OPENSEARCH,
FILESYSTEM
JDBC
Copy link
Copy Markdown
Collaborator Author

@penghuo penghuo Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FILESYSTEM supported has been removed in #1284.

penghuo
penghuo commented Feb 16, 2023
View reviewed changes
core/build.gradle
useJUnitPlatform()
testLogging {
events "passed", "skipped", "failed"
events "skipped", "failed"
Copy link
Copy Markdown
Collaborator Author

@penghuo penghuo Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore log PASSED test cases.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 16, 2023 •
edited
Loading

Codecov Report

Merging #1354 (ef27088) into main (98fb969) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #1354      +/-   ##
============================================
- Coverage     98.38%   98.38%   -0.01%     
+ Complexity     3698     3695       -3     
============================================
  Files           343      343              
  Lines          9121     9113       -8     
  Branches        586      582       -4     
============================================
- Hits           8974     8966       -8     
  Misses          142      142              
  Partials          5        5
Flag Coverage Δ
sql-engine 98.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/opensearch/sql/analysis/Analyzer.java 100.00% <100.00%> (ø)
...expression/function/BuiltinFunctionRepository.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@penghuo penghuo marked this pull request as ready for review February 27, 2023 16:20
@penghuo penghuo requested a review from a team as a code owner February 27, 2023 16:20
@penghuo penghuo requested a review from vamsimanohar February 27, 2023 16:21
anirudha
anirudha previously approved these changes Mar 6, 2023
View reviewed changes
@penghuo
Copy link
Copy Markdown
Collaborator Author

penghuo commented Mar 6, 2023

To reviewer: Ignore failed bwc test.

YANG-DB
YANG-DB previously approved these changes Mar 6, 2023
View reviewed changes
dai-chen
dai-chen previously approved these changes Mar 6, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@dai-chen dai-chen added the maintenance Improves code quality, but not the product label Mar 6, 2023
@penghuo
Merge branch 'main' into pr/spark/resolver
ef27088 
Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo dismissed stale reviews from dai-chen, YANG-DB, and anirudha via ef27088 March 9, 2023 01:43
@penghuo
Merge branch 'main' into pr/spark/resolver
0b2984d 
Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo merged commit bcfda37 into opensearch-project:main Mar 10, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 10, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 10, 2023
@penghuo @github-actions
Resolve table function based StorageEngine provided function resolver (…
d0e2db9 
…#1354)

Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit bcfda37)
penghuo added a commit that referenced this pull request Mar 14, 2023
@opensearch-trigger-bot @penghuo
Resolve table function based StorageEngine provided function resolver (…
0b6e581 
…#1354) (#1424)

Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit bcfda37)

Co-authored-by: Peng Huo <penghuo@gmail.com>
@dai-chen dai-chen mentioned this pull request Mar 14, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ps48 ps48 ps48 approved these changes

@anirudha anirudha anirudha left review comments

@dai-chen dai-chen dai-chen left review comments

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar vamsimanohar is a code owner

+1 more reviewer

@YANG-DB YANG-DB YANG-DB approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@penghuo penghuo

Labels

backport 2.x maintenance Improves code quality, but not the product spark integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@penghuo @codecov-commenter @anirudha @ps48 @dai-chen @YANG-DB