Updated EXPM1() and Tests to New Engine#1334
Merged
Yury-Fridlyand merged 1 commit intoopensearch-project:mainfrom Feb 14, 2023
Merged
Updated EXPM1() and Tests to New Engine#1334Yury-Fridlyand merged 1 commit intoopensearch-project:mainfrom
Yury-Fridlyand merged 1 commit intoopensearch-project:mainfrom
Conversation
* Updated EXPM1() and tests to new engine Signed-off-by: Matthew Wells <matthew.wells@improving.com> * Added EXPM1 to PPL Parser Signed-off-by: Matthew Wells <matthew.wells@improving.com> * Added documentation for EXPM1 PPL and fixed small mistake in EXP documentation Signed-off-by: Matthew Wells <matthew.wells@improving.com> * Added newline to fix code style issue Signed-off-by: Matthew Wells <matthew.wells@improving.com> * removed unnecessary integration tests and fixed typo in another test Signed-off-by: Matthew Wells <matthew.wells@improving.com> * Extracted common code from math functions into external function Signed-off-by: Matthew Wells <matthew.wells@improving.com> * Added javadoc comment to new function Signed-off-by: Matthew Wells <matthew.wells@improving.com> * Improved Javadoc Signed-off-by: Matthew Wells <matthew.wells@improving.com> * Added and improved EXPM1 tests, and improved documentation for CLI and PPL Signed-off-by: Matthew Wells <matthew.wells@improving.com> * Removed EXPM1 from PPL Signed-off-by: Matthew Wells <matthew.wells@improving.com> * Updated math base function to take any type and included more functions to use the base Signed-off-by: Matthew Wells <matthew.wells@improving.com> * Made tiny change to documentation Signed-off-by: Matthew Wells <matthew.wells@improving.com> * reverted euler function to previous iteration as the one I made didn't work Signed-off-by: Matthew Wells <matthew.wells@improving.com> * fixed typo in a comment that I made in a previous commit Signed-off-by: Matthew Wells <matthew.wells@improving.com> * fixed a mistake I made in fixing the typo from my last commit Signed-off-by: Matthew Wells <matthew.wells@improving.com> * Fixed spacing inconsistencies in math.rst file Signed-off-by: Matthew Wells <matthew.wells@improving.com> * removed the base math function so that it can be pushed in a seperate pull request Signed-off-by: Matthew Wells <matthew.wells@improving.com> * Reverted reverted change that removes the refactoring as this will be done in one commit Signed-off-by: Matthew Wells <matthew.wells@improving.com> * updated base function to have more descriptive variables Signed-off-by: Matthew Wells <matthew.wells@improving.com> --------- Signed-off-by: Matthew Wells <matthew.wells@improving.com>
10 tasks
dai-chen
approved these changes
Feb 14, 2023
Collaborator
dai-chen
left a comment
There was a problem hiding this comment.
Thanks for the changes! Shall we send separate PR for PPL?
Collaborator
Seems like a low priority. We can raise a separate issue to create PPL equivalents. |
MaxKsyunz
approved these changes
Feb 14, 2023
Collaborator
I wonder is this function for PPL low priority or having same scalar function set between SQL and PPL low priority? |
Collaborator
|
This function was migrated from the legacy engine. It is pretty useless though, because |
Collaborator
acarbonetto
approved these changes
Feb 14, 2023
penghuo
pushed a commit
that referenced
this pull request
Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthew Wells matthew.wells@improving.com
Description
Updated EXPM1 function to run on the new engine, as well as added integration tests and unit tests. In addition also extracted common code that was repeated in many functions into a standalone base function they can call.
Issues Resolved
#1190
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.