Skip to content

Support implicit type conversion from string to temporal#129

Closed
dai-chen wants to merge 17 commits intoopensearch-project:developfrom
dai-chen:support-implicit-cast-from-string-to-date
Closed

Support implicit type conversion from string to temporal#129
dai-chen wants to merge 17 commits intoopensearch-project:developfrom
dai-chen:support-implicit-cast-from-string-to-date

Conversation

@dai-chen
Copy link
Copy Markdown
Collaborator

@dai-chen dai-chen commented Jun 16, 2021

Description

Support implicit type conversion from STRING to DATE, TIME, TIMESTAMP, DATETIME.

Issues Resolved

#114

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dai-chen added 14 commits June 9, 2021 11:24
@dai-chen
Support implicit type conversion for bool and string
392fd31 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Fix lucene query pushdown issue
bc81106 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Refactor lucene query methods
c6357e4 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Refactor builtin repo methods
db895d6 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Add comparison test
5110f4d 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Fix comparison test
45f59de 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Add doc test for user manual
8863fa7 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Fix doc test
4402294 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Fix design doc link
e747585 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Fix RST render issue
bc8b67c 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Fix cast function pushdown issue
d7d9a2c 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Improve javadoc for PR
faf3fd3 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Upload design doc
2defbae 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Support implicit cast from string to temporal types
a1561c5 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen added enhancement New feature or request SQL PPL Piped processing language labels Jun 16, 2021
@dai-chen dai-chen self-assigned this Jun 16, 2021
dai-chen added 3 commits June 16, 2021 14:42
@dai-chen
Add comparison test
69b8417 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Add doctest
42b5652 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Fix doctest
659ed2f 
Signed-off-by: Chen Dai <daichen@amazon.com>
@davidcui1225 davidcui1225 deleted the branch opensearch-project:develop June 26, 2021 00:47
@dai-chen dai-chen mentioned this pull request Jul 28, 2021
Merged
6 tasks
@acarbonetto acarbonetto mentioned this pull request Oct 7, 2022
Closed
dai-chen pushed a commit that referenced this pull request Jan 26, 2023
@Yury-Fridlyand
Extend comparison methods to accept different datetime types. (#129) (#…
a4f8066 
…1196)

* Extend comparison methods to accept different datetime types. (#129)

* Extend comparison methods to accept different datetime types.

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Typo fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Rework fix according to @dai-chen's comment.
#1196 (review)

* Revert `BinaryPredicateOperator`.
* Add automatic cast rules `DATE`/`TIME`/`DATETIME` -> `DATETIME`/TIMESTAMP`.
* Update unit tests.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Add doctest sample.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Docs typo fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Minor comments update.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Doctest typo fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Doctest typo fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Doctest typo fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Modify `ExprCoreType` dependencies.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 26, 2023
@Yury-Fridlyand @github-actions
Extend comparison methods to accept different datetime types. (#129) (#…
42a787b 
…1196)

* Extend comparison methods to accept different datetime types. (#129)

* Extend comparison methods to accept different datetime types.

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Typo fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Rework fix according to @dai-chen's comment.
#1196 (review)

* Revert `BinaryPredicateOperator`.
* Add automatic cast rules `DATE`/`TIME`/`DATETIME` -> `DATETIME`/TIMESTAMP`.
* Update unit tests.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Add doctest sample.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Docs typo fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Minor comments update.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Doctest typo fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Doctest typo fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Doctest typo fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Modify `ExprCoreType` dependencies.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit a4f8066)
dai-chen pushed a commit that referenced this pull request Jan 26, 2023
@opensearch-trigger-bot @Yury-Fridlyand
Extend comparison methods to accept different datetime types. (#129) (#…
982d366 
…1196) (#1294)

* Extend comparison methods to accept different datetime types. (#129)

* Extend comparison methods to accept different datetime types.

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Typo fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Rework fix according to @dai-chen's comment.
#1196 (review)

* Revert `BinaryPredicateOperator`.
* Add automatic cast rules `DATE`/`TIME`/`DATETIME` -> `DATETIME`/TIMESTAMP`.
* Update unit tests.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Add doctest sample.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Docs typo fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Minor comments update.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Doctest typo fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Doctest typo fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Doctest typo fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Modify `ExprCoreType` dependencies.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit a4f8066)

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dai-chen dai-chen

Labels

enhancement New feature or request PPL Piped processing language SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dai-chen @davidcui1225