Add indices:admin/close* to list of permissible index permissions#1323
Merged
cwperks merged 2 commits intoopensearch-project:mainfrom Feb 20, 2023
Merged
Add indices:admin/close* to list of permissible index permissions#1323cwperks merged 2 commits intoopensearch-project:mainfrom
cwperks merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1323 +/- ##
=======================================
Coverage 71.78% 71.78%
=======================================
Files 88 88
Lines 2027 2027
Branches 274 274
=======================================
Hits 1455 1455
Misses 509 509
Partials 63 63
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
peternied
approved these changes
Feb 14, 2023
3 tasks
DarshitChanpura
approved these changes
Feb 14, 2023
stephen-crawford
approved these changes
Feb 14, 2023
RyanL1997
approved these changes
Feb 14, 2023
This was referenced Feb 14, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
) Signed-off-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Peter Nied <petern@amazon.com> (cherry picked from commit d5441b2)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Craig Perkins cwperx@amazon.com
Description
Adds
indices:admin/close*to list of permissible index permissions to cover associated close actions like TransportVerifyShardBeforeCloseAction. (Action name:indices:admin/close[s])Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
Bug Fix
Issues Resolved
opensearch-project/security#1461
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.