[Feature Branch] Add constants and specify types#1144
Merged
cliu123 merged 1 commit intoopensearch-project:2.x_aggregation_viewfrom Oct 17, 2022
Merged
Conversation
Signed-off-by: Chang Liu <lc12251109@gmail.com>
d8a91f1 to
b28e780
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x_aggregation_view #1144 +/- ##
=====================================================
Coverage 74.29% 74.29%
=====================================================
Files 86 86
Lines 1879 1879
Branches 246 246
=====================================================
Hits 1396 1396
Misses 426 426
Partials 57 57 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cliu123
added a commit
that referenced
this pull request
Oct 17, 2022
Signed-off-by: Chang Liu <lc12251109@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chang Liu lc12251109@gmail.com
Description
[Describe what this change achieves]
Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
Why these changes are required?
What is the old behavior before changes and new behavior after changes?
Issues Resolved
[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.