Clear the sessionStorage when logging out#1003
Merged
peternied merged 1 commit intoopensearch-project:mainfrom Jun 1, 2022
Merged
Clear the sessionStorage when logging out#1003peternied merged 1 commit intoopensearch-project:mainfrom
peternied merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Miki <miki@amazon.com>
ashwin-pc
approved these changes
Jun 1, 2022
DarshitChanpura
approved these changes
Jun 1, 2022
peternied
approved these changes
Jun 1, 2022
Member
peternied
left a comment
There was a problem hiding this comment.
Thanks for making this change @AMoo-Miki
spartan2015
pushed a commit
to spartan2015/security-dashboards-plugin
that referenced
this pull request
Aug 8, 2022
Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Vasile Negru <vasile@eosfintek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Miki miki@amazon.com
Description
OSD uses the browser's
sessionStorageto store potentially sensitive information. This change clears thesessionStorageduring logout.Category
Enhancement
Why these changes are required?
Without this, potentially sensitive information is left in the
sessionStorage.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.