Rollover for alerts/findings history indices#82
Merged
eirsep merged 21 commits intoopensearch-project:mainfrom Nov 3, 2022
Merged
Rollover for alerts/findings history indices#82eirsep merged 21 commits intoopensearch-project:mainfrom
eirsep merged 21 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Contributor
Author
|
After alerting 2.4 distribution is built, tests will pass. |
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Member
getsaurabh02
left a comment
There was a problem hiding this comment.
Can we have the naming consistent for other indices in SAP with a common prefix as well in such as :
/.opensearch-detectors-config
/.opensearch-pre-packaged-rules-config
/.opensearch-custom-rules-config
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
8d20945 to
3eaf0d0
Compare
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #82 +/- ##
============================================
- Coverage 42.65% 40.63% -2.02%
+ Complexity 882 878 -4
============================================
Files 173 174 +1
Lines 6023 6317 +294
Branches 750 772 +22
============================================
- Hits 2569 2567 -2
- Misses 3217 3511 +294
- Partials 237 239 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
getsaurabh02
previously approved these changes
Oct 31, 2022
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
eirsep
approved these changes
Nov 1, 2022
eirsep
previously approved these changes
Nov 1, 2022
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
getsaurabh02
previously approved these changes
Nov 1, 2022
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
…into alerts_findings_rollover
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
eirsep
approved these changes
Nov 3, 2022
sbcd90
approved these changes
Nov 3, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 3, 2022
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> (cherry picked from commit 95f8d9a)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 3, 2022
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> (cherry picked from commit 95f8d9a)
eirsep
pushed a commit
that referenced
this pull request
Nov 3, 2022
eirsep
pushed a commit
that referenced
this pull request
Nov 3, 2022
phaseshiftg
pushed a commit
to phaseshiftg/security-analytics
that referenced
this pull request
Nov 5, 2022
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Petar Dzepina petar.dzepina@gmail.com
Description
Rollover for alerts/findings history indices
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.