[Backport 2.x] fix null query filter conversion from sigma to query string query#813
Merged
jowg-amazon merged 1 commit into2.xfrom Feb 6, 2024
Merged
Conversation
* fix null query filter conversion from sigma to query string query Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix rule to query conversion tests for null filter Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * enhance test to verify non null doc doesnt match null query Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit a59a014)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #813 +/- ##
=========================================
Coverage 24.83% 24.83%
Complexity 1024 1024
=========================================
Files 277 277
Lines 12683 12683
Branches 1389 1389
=========================================
Hits 3150 3150
Misses 9267 9267
Partials 266 266 ☔ View full report in Codecov by Sentry. |
jowg-amazon
approved these changes
Feb 5, 2024
praveensameneni
approved these changes
Feb 6, 2024
eirsep
added a commit
to eirsep/security-analytics
that referenced
this pull request
Mar 13, 2024
…ensearch-project#722) (opensearch-project#813) * fix null query filter conversion from sigma to query string query Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix rule to query conversion tests for null filter Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * enhance test to verify non null doc doesnt match null query Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit a59a014) Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
eirsep
added a commit
to eirsep/security-analytics
that referenced
this pull request
Mar 13, 2024
…ensearch-project#722) (opensearch-project#813) * fix null query filter conversion from sigma to query string query Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix rule to query conversion tests for null filter Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * enhance test to verify non null doc doesnt match null query Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit a59a014) Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Mar 25, 2024
…ject#812) (opensearch-project#813) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport a59a014 from #722