Delete detector successfully if workflow is missing (#790)#806
Merged
engechas merged 1 commit intoopensearch-project:2.10from Mar 11, 2024
Merged
Delete detector successfully if workflow is missing (#790)#806engechas merged 1 commit intoopensearch-project:2.10from
engechas merged 1 commit intoopensearch-project:2.10from
Conversation
…ct#790) * Delete detector successfully if workflow is missing Signed-off-by: Chase Engelbrecht <engechas@amazon.com> * Refactor to use existing NotFound exception checker Signed-off-by: Chase Engelbrecht <engechas@amazon.com> --------- Signed-off-by: Chase Engelbrecht <engechas@amazon.com> (cherry picked from commit 0ad91cc)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #806 +/- ##
============================================
- Coverage 25.03% 25.02% -0.02%
Complexity 941 941
============================================
Files 255 255
Lines 11125 11131 +6
Branches 1242 1242
============================================
Hits 2785 2785
- Misses 8089 8095 +6
Partials 251 251 ☔ View full report in Codecov by Sentry. |
jowg-amazon
approved these changes
Jan 16, 2024
goyamegh
approved these changes
Mar 11, 2024
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Mar 25, 2024
…oject#804) (opensearch-project#806) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chase Engelbrecht engechas@amazon.com
Signed-off-by: Chase Engelbrecht engechas@amazon.com
Signed-off-by: Chase Engelbrecht engechas@amazon.com
(cherry picked from commit 0ad91cc)
Description
Manual conflict resolution + backport to 2.10
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.