Upgrade Lucene Codec to Lucene99 + Upgrade to Gradle 8.5#800
Upgrade Lucene Codec to Lucene99 + Upgrade to Gradle 8.5#800sbcd90 merged 5 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Joanne Wang <jowg@amazon.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #800 +/- ##
============================================
+ Coverage 24.73% 24.78% +0.05%
- Complexity 1023 1027 +4
============================================
Files 275 277 +2
Lines 12695 12709 +14
Branches 1400 1400
============================================
+ Hits 3140 3150 +10
- Misses 9290 9294 +4
Partials 265 265 ☔ View full report in Codecov by Sentry. |
|
why do we need both old and new codec? what was the previous code being used? |
|
are there any backward compatibility issues when customer upgrades from a version with previous codec to this? |
|
Asked @sbcd90 yesterday about keeping the old codec and he said it would be good to keep. K-nn keeps their old codecs for backwards compatibility which is why I kept both old and new codec. Don't know how to test this as we don't have a BWC workflow set up yet. |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-800-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 988377a5f26cb7eedf13cb075a8e9624c29b78a8
# Push it to GitHub
git push --set-upstream origin backport/backport-800-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
Signed-off-by: Joanne Wang <jowg@amazon.com> Co-authored-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 988377a)
Description
This PR includes the following changes:
Add new codec that wraps Lucene Codec 99 and make it default
Fix import statements for Lucene Codec 95
Change
CorrelationCode990andCorrelationCodec950constructor to typePerFieldKnnVectorsFormatto abstract the field type.Upgrades to gradle 8.5
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.