Skip to content

[Backport 2.11] #725 Sigma keywords field not handled correctly#741

Merged
jowg-amazon merged 1 commit intoopensearch-project:2.11from
jowg-amazon:bp725to2.11
Nov 30, 2023
Merged

[Backport 2.11] #725 Sigma keywords field not handled correctly#741
jowg-amazon merged 1 commit intoopensearch-project:2.11from
jowg-amazon:bp725to2.11

Conversation

@jowg-amazon
Copy link
Copy Markdown
Collaborator

@jowg-amazon jowg-amazon commented Nov 29, 2023

Description

Backport #725 to 2.11

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joanne Wang <jowg@amazon.com>

* remove wildcard

Signed-off-by: Joanne Wang <jowg@amazon.com>

* changed wildcardtest

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed wildcards

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed wildcard query test

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed correlation engine tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed query backend tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* clean up

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added two integration tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

---------

Signed-off-by: Joanne Wang <jowg@amazon.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80e028d) 24.71% compared to head (4c57f4a) 24.63%.

Additional details and impacted files
@@             Coverage Diff              @@
##               2.11     #741      +/-   ##
============================================
- Coverage     24.71%   24.63%   -0.09%     
+ Complexity      946      943       -3     
============================================
  Files           255      255              
  Lines         11376    11369       -7     
  Branches       1280     1279       -1     
============================================
- Hits           2812     2801      -11     
- Misses         8313     8318       +5     
+ Partials        251      250       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jowg-amazon jowg-amazon changed the title [Backport 2.11] #683 Sigma keywords field not handled correctly [Backport 2.11] #725 Sigma keywords field not handled correctly Nov 30, 2023
@jowg-amazon jowg-amazon merged commit 4da8a68 into opensearch-project:2.11 Nov 30, 2023
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
* added categories for log types

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* fixed cypress tests

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants