Skip to content

Test for the type of function used to declare findingIds[Ishan Bhat]#666

Closed
ishanbhat2004 wants to merge 12 commits intoopensearch-project:mainfrom
ishanbhat2004:bhat52/alerts
Closed

Test for the type of function used to declare findingIds[Ishan Bhat]#666
ishanbhat2004 wants to merge 12 commits intoopensearch-project:mainfrom
ishanbhat2004:bhat52/alerts

Conversation

@ishanbhat2004
Copy link
Copy Markdown

@ishanbhat2004 ishanbhat2004 commented Oct 16, 2023

Description

Check for the function to use to store findingIds

Issues Resolved

FindingIds can now be used to search for alerts in the database.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
@eirsep
Copy link
Copy Markdown
Member

eirsep commented Oct 26, 2023

thanks for raising this PR @ishanbhat2004

Can you add more detail in the description regarding the change? It's not very clear what this PR aims to do

ishanbhat2004 and others added 10 commits November 7, 2023 20:51
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Mar 25, 2024
…search-project#666) (opensearch-project#668)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 0fb9dd04ccd1356b67e320173954cbc928eba4fd)

Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
@ishanbhat2004 ishanbhat2004 deleted the bhat52/alerts branch July 28, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants