Auto expand replicas by lezzago · Pull Request #539 · opensearch-project/security-analytics

lezzago · 2023-09-06T17:41:17Z

Description

Auto expand replicas so for single node clusters, it wouldn't try to create a replica and cause the cluster to be yellow

Issues Resolved

N/A

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

eirsep · 2023-09-06T17:44:39Z

src/main/java/org/opensearch/securityanalytics/util/RuleIndices.java

        if (!ruleIndexExists(isPrepackaged)) {
+            Settings indexSettings = Settings.builder()
+                    .put("index.hidden", true)
+                    .put("index.auto_expand_replicas", "0-all")


was this a miss?

have we already added this setting this for other system indices in SAP?

These indices are auto generated, so it would cause single node clusters starting up to immediately be in a yellow state even if they do not use the plugin.

codecov · 2023-09-06T17:49:04Z

Codecov Report

Merging #539 (c06e818) into main (5178cc0) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #539      +/-   ##
============================================
- Coverage     25.77%   25.76%   -0.01%     
  Complexity      942      942              
============================================
  Files           252      252              
  Lines         10768    10772       +4     
  Branches       1197     1197              
============================================
  Hits           2775     2775              
- Misses         7746     7750       +4     
  Partials        247      247

Files Changed	Coverage Δ
...opensearch/securityanalytics/util/RuleIndices.java	`0.00% <0.00%> (ø)`

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 1003936)

* auto expand replicas (#539) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 1003936) * Remove extra import Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Ashish Agrawal <ashish81394@gmail.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>

* auto expand replicas (#539) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Correlation engine ux (opensearch-project#524) * wip Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * completed rules page; added placeholder for findings flyout tabs Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * reverted change to show empty table Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated rule type Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated create correlation rule page Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * correlation page wip Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Correlation store and API services Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Correlation store and API services Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Correlation store and API services Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Correlation store and API services Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Correlation store and API services Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated correlations page Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated store interfaces Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed correlation store Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * added api for all correlations Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * added filter support for correlations Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * using apis; added validation Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Implemented logic to populate correlations tables data. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * restricted to AND Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * log type clearable Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * code cleanup Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fixed API issue Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshots Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * ux improvements Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * code cleanup Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * removed redundant code Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * removed unwanted param Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * connected refresh Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Co-authored-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit f565a923c6bfec1b8a69128d21e5d823a50cb142) * Removed duplicate import for EuiSpacer (opensearch-project#538) (opensearch-project#540) * removed duplicate import * updated snapshots --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Pinned babel traverse and core (opensearch-project#539) (opensearch-project#544) * pinned babel traverse and core * removed cyclic dependency * added types for vis * refactored code --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

auto expand replicas

c06e818

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

lezzago requested review from AWSHurneyt, amsiglan, eirsep, getsaurabh02, praveensameneni and sbcd90 as code owners September 6, 2023 17:41

lezzago added backport 2.x backport 2.4 backport 2.5 backport 2.6 backport 2.7 backport 2.8 backport 2.9 backports to 2.9 labels Sep 6, 2023

eirsep reviewed Sep 6, 2023

View reviewed changes

eirsep approved these changes Sep 7, 2023

View reviewed changes

sbcd90 approved these changes Sep 7, 2023

View reviewed changes

sbcd90 merged commit 1003936 into opensearch-project:main Sep 7, 2023

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023

auto expand replicas (#539)

890d2d9

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 1003936)

opensearch-trigger-bot bot mentioned this pull request Sep 7, 2023

[Backport 2.x] Auto expand replicas #547

Merged

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023

auto expand replicas (#539)

890703c

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 1003936)

This was referenced Sep 7, 2023

[Backport 2.4] Auto expand replicas #548

Merged

[Backport 2.5] Auto expand replicas #549

Merged

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023

auto expand replicas (#539)

21f0b9c

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 1003936)

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023

auto expand replicas (#539)

d898536

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 1003936)

opensearch-trigger-bot bot mentioned this pull request Sep 7, 2023

[Backport 2.6] Auto expand replicas #550

Merged

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023

auto expand replicas (#539)

20de2b9

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 1003936)

opensearch-trigger-bot bot mentioned this pull request Sep 7, 2023

[Backport 2.7] Auto expand replicas #551

Merged

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023

auto expand replicas (#539)

185a81e

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 1003936)

opensearch-trigger-bot bot mentioned this pull request Sep 7, 2023

[Backport 2.8] Auto expand replicas #552

Merged

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023

auto expand replicas (#539)

5ceb374

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 1003936)

opensearch-trigger-bot bot mentioned this pull request Sep 7, 2023

[Backport 2.9] Auto expand replicas #553

Merged

lezzago added the backport 2.10 label Sep 7, 2023

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023

auto expand replicas (#539)

f4dfe0e

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 1003936)

opensearch-trigger-bot bot mentioned this pull request Sep 7, 2023

[Backport 2.10] Auto expand replicas #554

Merged

sbcd90 pushed a commit that referenced this pull request Sep 13, 2023

[Backport 2.7] Auto expand replicas (#551)

cd23067

* auto expand replicas (#539) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto expand replicas#539

Auto expand replicas#539
sbcd90 merged 1 commit intoopensearch-project:mainfrom
lezzago:system-indice-replica

lezzago commented Sep 6, 2023

Uh oh!

eirsep Sep 6, 2023 •

edited

Loading

Uh oh!

lezzago Sep 7, 2023

Uh oh!

codecov bot commented Sep 6, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

lezzago commented Sep 6, 2023

Description

Issues Resolved

Check List

Uh oh!

eirsep Sep 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lezzago Sep 7, 2023

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eirsep Sep 6, 2023 •

edited

Loading

codecov bot commented Sep 6, 2023 •

edited

Loading