add mitre attack based auto-correlations support in correlation engine#532
add mitre attack based auto-correlations support in correlation engine#532sbcd90 merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
|
plz add more elaborate description |
| @@ -0,0 +1,9625 @@ | |||
| { | |||
There was a problem hiding this comment.
we generated this from https://github.com/mitre/cti
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #532 +/- ##
============================================
- Coverage 25.72% 25.47% -0.26%
- Complexity 938 942 +4
============================================
Files 252 253 +1
Lines 10768 10895 +127
Branches 1197 1223 +26
============================================
+ Hits 2770 2775 +5
- Misses 7749 7873 +124
+ Partials 249 247 -2
|
| try { | ||
| generateAutoCorrelations(detector, finding); | ||
| } catch (IOException ex) { | ||
| correlateFindingAction.onFailures(ex); |
There was a problem hiding this comment.
can we log error message that auto correlation has failed
| int idx = 0; | ||
| for (MultiSearchResponse.Item response : responses) { | ||
| if (response.isFailure()) { | ||
| log.info(response.getFailureMessage()); |
There was a problem hiding this comment.
why info log? error or debug would be better. along with description message of what this failure is from?
eirsep
left a comment
There was a problem hiding this comment.
I am approving this
but can we take a follow up action item to add code comments.
This will make the repo and this feature more maintainable and understandable to community
|
updated to a more verbose description. added review comments to issue #502 |
Description
Findings in security-analytics link sigma rules to logs. Each sigma rule is linked to one or more mitre tactics & techniques. this info along with mitre cti relationships are used to generate auto-correlations among findings.
this pr add mitre attack based auto-correlations support in correlation engine. https://github.com/mitre/cti
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.