Skip to content

New rules an Mappings fixes#404

Closed
petardz wants to merge 19 commits intoopensearch-project:mainfrom
petardz:new-rule-types-and-fixes
Closed

New rules an Mappings fixes#404
petardz wants to merge 19 commits intoopensearch-project:mainfrom
petardz:new-rule-types-and-fixes

Conversation

@petardz
Copy link
Copy Markdown
Contributor

@petardz petardz commented Apr 18, 2023

Description

Fixes various bugs with mappings

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@petardz petardz requested a review from a team April 18, 2023 20:35
@petardz petardz force-pushed the new-rule-types-and-fixes branch 2 times, most recently from 00521f9 to d2aee59 Compare April 18, 2023 21:02
getsaurabh02
getsaurabh02 previously approved these changes Apr 19, 2023
@petardz petardz force-pushed the new-rule-types-and-fixes branch 2 times, most recently from c9653a6 to 6963fa0 Compare April 19, 2023 20:48
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #404 (43d96fa) into main (acfef46) will increase coverage by 0.03%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #404      +/-   ##
============================================
+ Coverage     28.33%   28.36%   +0.03%     
- Complexity      897      899       +2     
============================================
  Files           231      231              
  Lines          9282     9289       +7     
  Branches       1072     1075       +3     
============================================
+ Hits           2630     2635       +5     
- Misses         6415     6418       +3     
+ Partials        237      236       -1     
Impacted Files Coverage Δ
...search/securityanalytics/mapper/MapperService.java 4.10% <0.00%> (-0.18%) ⬇️
...ecurityanalytics/rules/backend/OSQueryBackend.java 66.95% <0.00%> (+0.57%) ⬆️
...opensearch/securityanalytics/util/RuleIndices.java 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

petardz added 17 commits May 4, 2023 02:38
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
…elds

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
…util.Map (opensearch-project#412)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
…nt sending fields which has same name as alias as "unmapped"

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz petardz force-pushed the new-rule-types-and-fixes branch from 9ee8e6e to 88154b5 Compare May 4, 2023 00:42
petardz added 2 commits May 4, 2023 02:49
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
* [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Unit tests for public components opensearch-project#383
[BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
@praveensameneni
Copy link
Copy Markdown
Member

@sbcd90 , can you please review the PR and update if we need this or can close it

@sbcd90 sbcd90 closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants