Handle monitor or monitor index not found during detector deletion#384
Merged
eirsep merged 1 commit intoopensearch-project:mainfrom Apr 12, 2023
Merged
Handle monitor or monitor index not found during detector deletion#384eirsep merged 1 commit intoopensearch-project:mainfrom
eirsep merged 1 commit intoopensearch-project:mainfrom
Conversation
a25107d to
5eec283
Compare
sbcd90
previously approved these changes
Apr 3, 2023
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
============================================
- Coverage 36.53% 35.66% -0.87%
Complexity 887 887
============================================
Files 185 186 +1
Lines 7098 7285 +187
Branches 860 885 +25
============================================
+ Hits 2593 2598 +5
- Misses 4268 4450 +182
Partials 237 237 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sbcd90
approved these changes
Apr 12, 2023
amsiglan
approved these changes
Apr 12, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-384-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6271399c381a33364927e8147b6d6e3bc3f583cc
# Push it to GitHub
git push --set-upstream origin backport/backport-384-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5Then, create a pull request where the |
eirsep
added a commit
that referenced
this pull request
Apr 12, 2023
petardz
pushed a commit
to petardz/security-analytics
that referenced
this pull request
May 2, 2023
…pensearch-project#384) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics
that referenced
this pull request
Jun 9, 2023
…pensearch-project#384) (opensearch-project#398) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit 6271399) Co-authored-by: Surya Sashank Nistala <snistala@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
5 tasks
AWSHurneyt
added a commit
that referenced
this pull request
Jun 9, 2023
* handle index not exists for detector search and delete (#396) (#397) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit e50c70a) Co-authored-by: Surya Sashank Nistala <snistala@amazon.com> * Handle monitor or monitor index not exists during detector deletion (#384) (#398) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit 6271399) Co-authored-by: Surya Sashank Nistala <snistala@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Feb 20, 2024
* [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] The detector details shouldn't have a wrapper around the whole page opensearch-project#384 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Handle monitor or monitor index(
.opendistro-alerting-config) not found during detector deletion to proceed with detector deletion.But if there are other errors thrown from monitor deletion then we log it and fail the request
Issues Resolved
#378
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.