Index template cleanup#317
Merged
sbcd90 merged 13 commits intoopensearch-project:mainfrom Feb 22, 2023
Merged
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #317 +/- ##
============================================
- Coverage 36.87% 35.89% -0.99%
Complexity 887 887
============================================
Files 179 186 +7
Lines 7032 7224 +192
Branches 857 870 +13
============================================
Hits 2593 2593
- Misses 4202 4394 +192
Partials 237 237
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
Appreciate sanitary fixes but let's not make them with bug fixes or feature PRs as it is cumbersome to track what's the actual change and what is simply an indentation fix or a sanitary change for readaiblity. plz raise such changes in different PR. |
eirsep
reviewed
Feb 21, 2023
src/main/java/org/opensearch/securityanalytics/transport/TransportSearchRuleAction.java
Outdated
Show resolved
Hide resolved
eirsep
reviewed
Feb 21, 2023
src/main/java/org/opensearch/securityanalytics/transport/TransportSearchRuleAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
…me; replaced v1 template with v2 template for query index template Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
6e89bd3 to
e9e8312
Compare
getsaurabh02
approved these changes
Feb 22, 2023
sbcd90
approved these changes
Feb 22, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> (cherry picked from commit 52afd47)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> (cherry picked from commit 52afd47)
sbcd90
pushed a commit
that referenced
this pull request
Feb 22, 2023
sbcd90
pushed a commit
that referenced
this pull request
Feb 22, 2023
eirsep
pushed a commit
to eirsep/security-analytics
that referenced
this pull request
Apr 3, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Feb 20, 2024
…PI call (opensearch-project#317) * create detector if mapping creation succeeds Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated creation api call sequence Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We're deleting all unused templates(v2) and componentTemplates on detector DELETE
Issues Resolved
#312
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.