Closed
Conversation
GetFinding supporting multiple detector types GetAlerts supporting multiple detector types Added multiple detector types in request model Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
…dded collection of detector types in input field Refactored tests and updated constructor from a Detector not to consider detector type property Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Added integration tests Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #232 +/- ##
============================================
- Coverage 38.97% 38.58% -0.39%
- Complexity 892 898 +6
============================================
Files 176 176
Lines 6746 6902 +156
Branches 823 846 +23
============================================
+ Hits 2629 2663 +34
- Misses 3876 3994 +118
- Partials 241 245 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Feb 20, 2024
…-project#232) * [FEATURE] Implement date/time picker on the overview page opensearch-project#133 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Implement date/time picker on the overview page opensearch-project#133 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.