Add release notes for 2.4.1#183
Merged
sbcd90 merged 1 commit intoopensearch-project:mainfrom Dec 13, 2022
Merged
Conversation
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
eirsep
approved these changes
Dec 13, 2022
getsaurabh02
approved these changes
Dec 13, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 13, 2022
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> (cherry picked from commit b7e5469)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 13, 2022
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> (cherry picked from commit b7e5469)
sbcd90
pushed a commit
that referenced
this pull request
Dec 13, 2022
sbcd90
pushed a commit
that referenced
this pull request
Dec 13, 2022
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Feb 20, 2024
…ect#183) * Implement cypress tests for Findings Signed-off-by: Chris Hesterman <phestech@amazon.com> * Progress with findings_spec Signed-off-by: Chris Hesterman <phestech@amazon.com> * Add tests for Finding details flyout Signed-off-by: Chris Hesterman <phestech@amazon.com> * Add comments. Keeping manual detector creation. Signed-off-by: Chris Hesterman <phestech@amazon.com> * Correct imports in detectors_spec.js Signed-off-by: Chris Hesterman <phestech@amazon.com> * Small refactor of findings_spec Signed-off-by: Chris Hesterman <phestech@amazon.com> * Remove leftover console.log Signed-off-by: Chris Hesterman <phestech@amazon.com> * Implement requested changes, findings_spec, fixtures/constants Signed-off-by: Chris Hesterman <phestech@amazon.com> * Make requested changes, 4_findings.spec, rename files Signed-off-by: Chris Hesterman <phestech@amazon.com> * Incorporate use of cypress url() for better testing Signed-off-by: Chris Hesterman <phestech@amazon.com> * Specify OSD 2.4.0 in cypress-workflow Signed-off-by: Chris Hesterman <phestech@amazon.com> * Change intermittently failing selector, detectors_spec Signed-off-by: Chris Hesterman <phestech@amazon.com> * Remove all specs but deteectors_spec for fix Signed-off-by: Chris Hesterman <phestech@amazon.com> * Resolve issues and brittleness in detectors_spec Signed-off-by: Chris Hesterman <phestech@amazon.com> * Resolve issues with detectors_spec, Make more durable Signed-off-by: Chris Hesterman <phestech@amazon.com> * Small changes to findings_spec Signed-off-by: Chris Hesterman <phestech@amazon.com> * Add timeout after create detector button clicked Signed-off-by: Chris Hesterman <phestech@amazon.com> * Add back hard wait instead of timeout. Signed-off-by: Chris Hesterman <phestech@amazon.com> * Add timeout before disable all rules Signed-off-by: Chris Hesterman <phestech@amazon.com> * Current progress, findings_spec refactor Signed-off-by: Chris Hesterman <phestech@amazon.com> * Add wait before detector name change, testing result Signed-off-by: Chris Hesterman <phestech@amazon.com> * Working solidly locally... again Signed-off-by: Chris Hesterman <phestech@amazon.com> * Refactor creation phase, detectors_spec Signed-off-by: Chris Hesterman <phestech@amazon.com> * Clean up unused code Signed-off-by: Chris Hesterman <phestech@amazon.com> * Working though issues findings_spec Signed-off-by: Chris Hesterman <phestech@amazon.com> * Working through icon button not being clicked Signed-off-by: Chris Hesterman <phestech@amazon.com> * Remove as many timeout/waits as possible while still pass Signed-off-by: Chris Hesterman <phestech@amazon.com> * Refactor findings.spec Signed-off-by: Chris Hesterman <phestech@amazon.com> * Update helpers.js to work with new mappings elements Signed-off-by: Chris Hesterman <phestech@amazon.com> * Change assertion to 'include', line 27 findings.spec Signed-off-by: Chris Hesterman <phestech@amazon.com> * Add url assertion after detector created to fix issue. Signed-off-by: Chris Hesterman <phestech@amazon.com> * Add check to confirm url before deleting test detector Signed-off-by: Chris Hesterman <phestech@amazon.com> * Changes in response to PR comments Signed-off-by: Chris Hesterman <phestech@amazon.com> * Make use of added commands to set up test env, findings.spec Signed-off-by: Chris Hesterman <phestech@amazon.com> Delete now obsolete 'helpers.js' in cypress/support Signed-off-by: Chris Hesterman <phestech@amazon.com> * Add timeout before clicking finding details icon Signed-off-by: Chris Hesterman <phestech@amazon.com> * Use existing commands to set up findings spec detector Signed-off-by: Chris Hesterman <phestech@amazon.com> Fix detectors spec after above change affected it. Signed-off-by: Chris Hesterman <phestech@amazon.com> * Make selection of finding id button more specific, findings.spec Signed-off-by: Chris Hesterman <phestech@amazon.com> * Remove commented code Signed-off-by: Chris Hesterman <phestech@amazon.com> * Fix details icon selector to account for multiple findings Signed-off-by: Chris Hesterman <phestech@amazon.com> * Resolve cy.visit causing two detectors to be created Signed-off-by: Chris Hesterman <phestech@amazon.com> trim/remove waits/timeouts as much as possible Signed-off-by: Chris Hesterman <phestech@amazon.com> * Change parameter name back to documentJSON, commands.js Signed-off-by: Chris Hesterman <phestech@amazon.com> * Update findings spec, sample_detector variables/names Signed-off-by: Chris Hesterman <phestech@amazon.com> * Change to have detector created after mappings, findings spec Signed-off-by: Chris Hesterman <phestech@amazon.com> * Address PR comments. Signed-off-by: Chris Hesterman <phestech@amazon.com> Signed-off-by: Chris Hesterman <phestech@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Subhobrata Dey sbcd90@gmail.com
Description
Add release notes for 2.4.1
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.