search returns detector type in CAPS fix and integration tests#174
Merged
sbcd90 merged 5 commits intoopensearch-project:mainfrom Dec 30, 2022
Merged
search returns detector type in CAPS fix and integration tests#174sbcd90 merged 5 commits intoopensearch-project:mainfrom
sbcd90 merged 5 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Raj Chakravarthi <raj@icedome.ca>
Signed-off-by: Raj Chakravarthi <raj@icedome.ca>
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
============================================
- Coverage 39.06% 38.94% -0.13%
Complexity 891 891
============================================
Files 176 176
Lines 6724 6746 +22
Branches 820 823 +3
============================================
Hits 2627 2627
- Misses 3856 3877 +21
- Partials 241 242 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Raj Chakravarthi <raj@icedome.ca>
Member
|
It's fine to return smallcase in response but we should be able to handle case agnostic input from client |
Signed-off-by: Raj Chakravarthi <raj@icedome.ca>
Signed-off-by: Raj Chakravarthi <raj@icedome.ca>
getsaurabh02
approved these changes
Dec 28, 2022
rishabhmaurya
approved these changes
Dec 30, 2022
lezzago
approved these changes
Dec 30, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 30, 2022
Signed-off-by: Raj Chakravarthi <raj@icedome.ca> (cherry picked from commit 1770873)
sbcd90
pushed a commit
that referenced
this pull request
Dec 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raj Chakravarthi raj@icedome.ca
Description
After this change, the detector type will be returned in small case during search.
Also, integration tests are written to ensure that happens in create, update, get , search detector.
Issues Resolved
(#173)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.