Move rules to config directory from classpath resources#1580
Merged
cwperks merged 11 commits intoopensearch-project:mainfrom Sep 25, 2025
Merged
Move rules to config directory from classpath resources#1580cwperks merged 11 commits intoopensearch-project:mainfrom
cwperks merged 11 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
…r commons Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
3 tasks
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
lezzago
approved these changes
Sep 24, 2025
eirsep
approved these changes
Sep 24, 2025
eirsep
approved these changes
Sep 24, 2025
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics/backport-2.19 2.19
# Navigate to the new working tree
pushd ../.worktrees/security-analytics/backport-2.19
# Create a new branch
git switch --create backport-1580-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 95dd12316a7e5c93bf1498a6c4960668342c3bed
# Push it to GitHub
git push --set-upstream origin backport-1580-to-2.19
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics/backport-2.19Then, create a pull request where the |
5 tasks
66 tasks
riysaxen-amzn
pushed a commit
that referenced
this pull request
Oct 10, 2025
…es (#1580) (#1584) * Move rules to config directory from classpath resources (#1580) * Remove direct reference to Job-Scheduler Lock Index in SAP repo Signed-off-by: Craig Perkins <cwperx@amazon.com> * Exclude error_prone_annotations from locally checked in shadow jar for commons Signed-off-by: Craig Perkins <cwperx@amazon.com> * Include apache httpcomponents Signed-off-by: Craig Perkins <cwperx@amazon.com> * Move rules to config directory from classpath resources Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fix tests Signed-off-by: Craig Perkins <cwperx@amazon.com> * Read from path directly Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fix prepackaged rules test Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 95dd123) * Change to 2.19.4 Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion core PR: opensearch-project/OpenSearch#19343
This PR moves all sigma rules (yaml files) from classpath resources to the config directory. These yaml files do not need to be bundled in the SAP jar itself, they just need to be readable at runtime. Files within a plugin's config folder are readable at runtime.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.