Skip to content

added support for index pattern as param to CreateIndexMappings#155

Closed
petardz wants to merge 29 commits intoopensearch-project:mainfrom
petardz:createindexmappings-indexpattern
Closed

added support for index pattern as param to CreateIndexMappings#155
petardz wants to merge 29 commits intoopensearch-project:mainfrom
petardz:createindexmappings-indexpattern

Conversation

@petardz
Copy link
Copy Markdown
Contributor

@petardz petardz commented Nov 12, 2022

Signed-off-by: Petar Dzepina petar.dzepina@gmail.com

Description

added support for index pattern as param to CreateIndexMappings

Issues Resolved

#154

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@petardz
added support for index pattern as param to CreateIndexMappings
6731e8b 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz petardz requested a review from a team November 12, 2022 00:37
@petardz
fixed test
96e11e8 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
createmappings tree copy fix
2ed990d 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
test compile fix
62dc805 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
fixed unit tests
a7cb40c 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@sbcd90
Copy link
Copy Markdown
Collaborator

sbcd90 commented Nov 18, 2022

hi @petardz , the pr looks good. can you resolve the warning messages also in the code if possible?

@sbcd90
Copy link
Copy Markdown
Collaborator

sbcd90 commented Nov 18, 2022

@petardz lets also discuss on enhancing this with get mappings/view api

@getsaurabh02
Copy link
Copy Markdown
Member

getsaurabh02 commented Dec 28, 2022

@petardz Can we address the requested changes

sbcd90
sbcd90 previously approved these changes Jan 3, 2023
View reviewed changes
...main/java/org/opensearch/securityanalytics/transport/TransportCreateIndexMappingsAction.java Outdated
if (index == null) {
actionListener.onFailure(new IllegalStateException("Could not find index [" + request.getIndexName() + "]"));
return;
}
Copy link
Copy Markdown
Collaborator

@sbcd90 sbcd90 Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to enhance the check if index or pattern exists or not instead of removing it?

Copy link
Copy Markdown
Contributor Author

@petardz petardz Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need I think. GET _mapping API will return mappings for all resolved indices in response.

@petardz
fixed javaDoc warnings
8288459 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 3, 2023 •
edited
Loading

Codecov Report

Merging #155 (d7b115d) into main (887be34) will decrease coverage by 1.25%.
The diff coverage is 4.95%.

@@             Coverage Diff              @@
##               main     #155      +/-   ##
============================================
- Coverage     38.02%   36.77%   -1.26%     
+ Complexity      887      882       -5     
============================================
  Files           176      179       +3     
  Lines          6795     6970     +175     
  Branches        834      849      +15     
============================================
- Hits           2584     2563      -21     
- Misses         3974     4171     +197     
+ Partials        237      236       -1
Impacted Files Coverage Δ
...rch/securityanalytics/SecurityAnalyticsPlugin.java 0.00% <0.00%> (ø)
...arch/securityanalytics/action/AckAlertsAction.java 0.00% <ø> (ø)
...search/securityanalytics/alerts/AlertsService.java 21.90% <ø> (ø)
...ch/securityanalytics/findings/FindingsService.java 36.48% <ø> (ø)
...securityanalytics/mapper/IndexTemplateManager.java 0.00% <0.00%> (ø)
...h/securityanalytics/model/CreateMappingResult.java 0.00% <0.00%> (ø)
.../opensearch/securityanalytics/util/IndexUtils.java 38.57% <0.00%> (-3.62%) ⬇️
...ensearch/securityanalytics/util/XContentUtils.java 0.00% <0.00%> (ø)
...search/securityanalytics/mapper/MapperService.java 4.45% <4.25%> (-12.99%) ⬇️
...ensearch/securityanalytics/mapper/MapperUtils.java 28.39% <43.75%> (+0.45%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

petardz added 17 commits January 4, 2023 02:29
@petardz
empty commit
fde1083 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
empty commit
fc86820 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
Merge branch 'main' of https://github.com/opensearch-project/security…
2888d7d 
…-analytics into createindexmappings-indexpattern
@petardz
empty commit
b3a351c 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
Merge branch 'main' of https://github.com/opensearch-project/security…
0ebd31c 
…-analytics into createindexmappings-indexpattern
@petardz
added some DEBUG log level in integTest
fc39f36 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
empty commit
6a8d7a7 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
empty commit
a770bf6 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
empty commit
a236949 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
empty commit
b12273b 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
Merge branch 'main' of https://github.com/opensearch-project/security…
8931b26 
…-analytics
@petardz
conflict resolve
296398b 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
added setting index templates
b3ca32a 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
Merge branch 'main' of https://github.com/petardz/security-analytics …
4dd35bc 
…into createindexmappings-indexpattern
@petardz
Merge branch 'main' of https://github.com/opensearch-project/security…
aa1145c 
…-analytics into createindexmappings-indexpattern
@petardz
improvements
4cb0740 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
added test for index template create/update with index pattern
a921dd2 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
fixed updating template composedOf array
bc68cb0 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@getsaurabh02
Copy link
Copy Markdown
Member

getsaurabh02 commented Jan 10, 2023

@petardz Can we resolve the conflict. LGTM

@petardz
more tests and ds fix
37d1e80 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
merge from main
49e4077 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
commented out temporarly MapperService unit tests
9f9c827 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
added headers
d7b115d 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
ec
b7dc22d 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@sbcd90 sbcd90 closed this Jan 11, 2023
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
@jovancvetkovic3006
[FEATURE] Adds color-blind and status palettes into charts (opensearc…
6adca68 
…h-project#182)

* [FEATURE] Alerts chart | Use euiPaletteColorBlind for charts opensearch-project#155

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Alerts chart | Use euiPaletteColorBlind for charts opensearch-project#155
[FEATURE] Chart grouping | Unify logType grouping fields for Overview and Findings opensearch-project#181

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Merge branch 'main' of https://github.com/opensearch-project/security-analytics-dashboards-plugin into feature/chart_legend_font_update

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbcd90 sbcd90 sbcd90 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@petardz @sbcd90 @getsaurabh02 @codecov-commenter