Skip to content

populate queries field in FindingDTO in case of bucket level monitor findings#148

Merged
eirsep merged 1 commit intoopensearch-project:mainfrom
eirsep:blm
Nov 11, 2022
Merged

populate queries field in FindingDTO in case of bucket level monitor findings#148
eirsep merged 1 commit intoopensearch-project:mainfrom
eirsep:blm

Conversation

@eirsep
Copy link
Copy Markdown
Member

@eirsep eirsep commented Nov 11, 2022

Signed-off-by: Surya Sashank Nistala snistala@amazon.com

Description

populate doc level queries field with a singleton list containing rule id in FindingDTO in case of bucket level monitor findings.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@eirsep eirsep requested a review from a team November 11, 2022 01:17
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 11, 2022

Codecov Report

Merging #148 (76c92ac) into main (68231e9) will decrease coverage by 0.04%.
The diff coverage is 18.18%.

@@             Coverage Diff              @@
##               main     #148      +/-   ##
============================================
- Coverage     39.19%   39.14%   -0.05%     
+ Complexity      891      890       -1     
============================================
  Files           176      176              
  Lines          6702     6708       +6     
  Branches        815      818       +3     
============================================
- Hits           2627     2626       -1     
- Misses         3834     3840       +6     
- Partials        241      242       +1     
Impacted Files Coverage Δ
...ch/securityanalytics/findings/FindingsService.java 36.48% <18.18%> (-3.22%) ⬇️
...g/opensearch/securityanalytics/model/Detector.java 70.24% <0.00%> (-0.35%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…findings

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@eirsep eirsep merged commit 2e44ff4 into opensearch-project:main Nov 11, 2022
@eirsep eirsep deleted the blm branch November 11, 2022 02:52
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 11, 2022
…findings (#148)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 2e44ff4)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 11, 2022
…findings (#148)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 2e44ff4)
eirsep added a commit that referenced this pull request Nov 11, 2022
…findings (#148) (#151)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 2e44ff4)

Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
eirsep added a commit that referenced this pull request Nov 11, 2022
…findings (#148) (#152)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 2e44ff4)

Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
…search-project#129 (opensearch-project#148)

* [FEATURE] Get started | Add Alert info in the Get started pop-up opensearch-project#129

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Get started | Add Alert info in the Get started pop-up opensearch-project#129

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Get started | Add Alert info in the Get started pop-up opensearch-project#129

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Get started | Add Alert info in the Get started pop-up opensearch-project#129

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Get started | Add Alert info in the Get started pop-up opensearch-project#129

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Get started | Add Alert info in the Get started pop-up opensearch-project#129

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants