Monitor execution and finding integration tests#139
Merged
sbcd90 merged 3 commits intoopensearch-project:mainfrom Nov 18, 2022
Merged
Monitor execution and finding integration tests#139sbcd90 merged 3 commits intoopensearch-project:mainfrom
sbcd90 merged 3 commits intoopensearch-project:mainfrom
Conversation
6336299 to
a76b747
Compare
Codecov Report
@@ Coverage Diff @@
## main #139 +/- ##
============================================
- Coverage 39.29% 39.06% -0.23%
- Complexity 889 891 +2
============================================
Files 176 176
Lines 6665 6724 +59
Branches 809 820 +11
============================================
+ Hits 2619 2627 +8
- Misses 3807 3856 +49
- Partials 239 241 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com>
Mostly cover the scenarios related with rule and monitor updates Updated integration tests when executing detectors to check and assert the findings Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com>
Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com>
92ba4ca to
c69669e
Compare
sbcd90
approved these changes
Nov 18, 2022
eirsep
approved these changes
Nov 18, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com> (cherry picked from commit a4a542d)
sbcd90
pushed a commit
that referenced
this pull request
Nov 18, 2022
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Mar 25, 2024
…rch-project#139 (opensearch-project#280) Signed-off-by: skkosuri-amzn <skkosuri@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stevan Buzejic stevan.buzejic@htecgroup.com
Description
Adds integration tests that should cover different use-cases of detector creation by focusing on behavior during monitor creation and verifying the findings.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.