Skip to content

removed grouped listener when fetching findings#124

Merged
eirsep merged 1 commit intoopensearch-project:mainfrom
petardz:getfindings-fix
Nov 9, 2022
Merged

removed grouped listener when fetching findings#124
eirsep merged 1 commit intoopensearch-project:mainfrom
petardz:getfindings-fix

Conversation

@petardz
Copy link
Copy Markdown
Contributor

@petardz petardz commented Nov 9, 2022

Signed-off-by: Petar Dzepina petar.dzepina@gmail.com

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz petardz requested a review from a team November 9, 2022 00:17
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #124 (0058786) into main (db97ea9) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #124      +/-   ##
============================================
+ Coverage     39.97%   40.15%   +0.17%     
- Complexity      882      883       +1     
============================================
  Files           175      175              
  Lines          6436     6433       -3     
  Branches        786      785       -1     
============================================
+ Hits           2573     2583      +10     
+ Misses         3626     3612      -14     
- Partials        237      238       +1     
Impacted Files Coverage Δ
...ch/securityanalytics/findings/FindingsService.java 39.70% <100.00%> (+14.35%) ⬆️
...g/opensearch/securityanalytics/model/Detector.java 70.50% <0.00%> (-0.36%) ⬇️
.../securityanalytics/action/GetFindingsResponse.java 35.29% <0.00%> (+11.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eirsep eirsep merged commit bb7ffb5 into opensearch-project:main Nov 9, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 9, 2022
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit bb7ffb5)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 9, 2022
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit bb7ffb5)
eirsep pushed a commit that referenced this pull request Nov 9, 2022
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit bb7ffb5)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
eirsep pushed a commit that referenced this pull request Nov 9, 2022
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit bb7ffb5)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants