mapper topics fix; Index Rule category validation#123
Merged
eirsep merged 2 commits intoopensearch-project:mainfrom Nov 10, 2022
Merged
mapper topics fix; Index Rule category validation#123eirsep merged 2 commits intoopensearch-project:mainfrom
eirsep merged 2 commits intoopensearch-project:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #123 +/- ##
============================================
- Coverage 39.29% 39.18% -0.11%
- Complexity 889 890 +1
============================================
Files 176 176
Lines 6665 6701 +36
Branches 809 815 +6
============================================
+ Hits 2619 2626 +7
- Misses 3807 3833 +26
- Partials 239 242 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eirsep
previously approved these changes
Nov 9, 2022
Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
33f4850 to
e38b32d
Compare
sbcd90
approved these changes
Nov 10, 2022
eirsep
approved these changes
Nov 10, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 10, 2022
* conflict resolve Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com> * IT fixes Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com> Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com> Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com> (cherry picked from commit 4fba8fc)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 10, 2022
* conflict resolve Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com> * IT fixes Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com> Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com> Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com> (cherry picked from commit 4fba8fc)
eirsep
pushed a commit
that referenced
this pull request
Nov 10, 2022
* conflict resolve Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com> * IT fixes Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com> Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com> Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com> (cherry picked from commit 4fba8fc) Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
eirsep
pushed a commit
that referenced
this pull request
Nov 10, 2022
* conflict resolve Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com> * IT fixes Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com> Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com> Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com> (cherry picked from commit 4fba8fc) Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Petar Dzepina petar.dzepina@gmail.com
Description
Fixed GetIndexMappings API to return proper errors for incorrect rule_topic. Added proper error handling for category param for IndexRule API
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.