Skip to content

fixed GetFindings not searching all indices; fixed proper deletion of…#122

Merged
eirsep merged 10 commits intoopensearch-project:mainfrom
petardz:index-managment-fixes
Nov 9, 2022
Merged

fixed GetFindings not searching all indices; fixed proper deletion of…#122
eirsep merged 10 commits intoopensearch-project:mainfrom
petardz:index-managment-fixes

Conversation

@petardz
Copy link
Copy Markdown
Contributor

@petardz petardz commented Nov 7, 2022

… old history indices

Signed-off-by: Petar Dzepina petar.dzepina@gmail.com

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@petardz
fixed GetFindings not searching all indices; fixed proper deletion of…
e95ffea 
… old history indices

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz petardz requested a review from a team November 7, 2022 22:53
@petardz
empty commit
b995ec2 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
added default values
fc1ccc7 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
Merge branch 'main' of https://github.com/opensearch-project/security…
b11fca3 
…-analytics into index-managment-fixes
@petardz
removed debug printlns
7daf822 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
fixed get alerts not searching history indices too
ac4e6a0 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
fixed flaky IT
43e2ea4 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
IT fix
7c9be49 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
empty commit
fb6d745 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 9, 2022 •
edited
Loading

Codecov Report

Merging #122 (a044fd4) into main (ee7f6fb) will decrease coverage by 0.88%.
The diff coverage is 22.22%.

@@             Coverage Diff              @@
##               main     #122      +/-   ##
============================================
- Coverage     40.16%   39.28%   -0.89%     
- Complexity      884      890       +6     
============================================
  Files           175      176       +1     
  Lines          6433     6684     +251     
  Branches        785      811      +26     
============================================
+ Hits           2584     2626      +42     
- Misses         3612     3816     +204     
- Partials        237      242       +5
Impacted Files Coverage Δ
...indexmanagment/DetectorIndexManagementService.java 0.00% <0.00%> (ø)
...alytics/config/monitors/DetectorMonitorConfig.java 53.84% <35.29%> (-1.71%) ⬇️
...search/securityanalytics/alerts/AlertsService.java 21.90% <50.00%> (ø)
...ch/securityanalytics/findings/FindingsService.java 39.70% <50.00%> (ø)
...ecurityanalytics/rules/backend/OSQueryBackend.java 66.37% <0.00%> (-8.91%) ⬇️
...g/opensearch/securityanalytics/model/Detector.java 70.24% <0.00%> (-0.63%) ⬇️
...a/org/opensearch/securityanalytics/model/Rule.java 0.00% <0.00%> (ø)
.../securityanalytics/rules/backend/QueryBackend.java 65.48% <0.00%> (ø)
...yanalytics/transport/TransportIndexRuleAction.java 0.00% <0.00%> (ø)
...lytics/transport/TransportIndexDetectorAction.java 0.00% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@petardz
finding IT fix
a044fd4 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@eirsep eirsep merged commit 8dd1c9f into opensearch-project:main Nov 9, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 9, 2022
@petardz @github-actions
fixed GetFindings not searching all indices; fixed proper deletion of… (
abef0ff 
#122)

* fixed GetFindings not searching all indices; fixed proper deletion of old history indices

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 8dd1c9f)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 9, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 9, 2022
@petardz @github-actions
fixed GetFindings not searching all indices; fixed proper deletion of… (
e44ccb2 
#122)

* fixed GetFindings not searching all indices; fixed proper deletion of old history indices

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 8dd1c9f)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 9, 2022
Merged
eirsep pushed a commit that referenced this pull request Nov 9, 2022
@opensearch-trigger-bot @petardz
fixed GetFindings not searching all indices; fixed proper deletion of… (
2a27e0f 
#122) (#136)

* fixed GetFindings not searching all indices; fixed proper deletion of old history indices

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 8dd1c9f)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
eirsep pushed a commit that referenced this pull request Nov 9, 2022
@opensearch-trigger-bot @petardz
fixed GetFindings not searching all indices; fixed proper deletion of… (
1a2a5f8 
#122) (#135)

* fixed GetFindings not searching all indices; fixed proper deletion of old history indices

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 8dd1c9f)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eirsep eirsep eirsep approved these changes

@getsaurabh02 getsaurabh02 getsaurabh02 approved these changes

Assignees

No one assigned

Labels

backport 2.x backport 2.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@petardz @codecov-commenter @eirsep @getsaurabh02