Merged
Conversation
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit 269be07)
sbcd90
approved these changes
Nov 4, 2022
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Feb 20, 2024
…ng (opensearch-project#111) * Begin implementing tests, findings_spec.js Signed-off-by: Chris Hesterman <phestech@amazon.com> * Fix imports, findings_spec.js Signed-off-by: Chris Hesterman <phestech@amazon.com> * Minor progress with findings_spec, getting detector created. Signed-off-by: Chris Hesterman <phestech@amazon.com> * Progress on findings_spec and detectors_spec Signed-off-by: Chris Hesterman <phestech@amazon.com> * Create detectors_spec, test creation, editing, deleting Signed-off-by: Chris Hesterman <phestech@amazon.com> * Bring findings_spec back to TODO status Signed-off-by: Chris Hesterman <phestech@amazon.com> * Adjust timing in "rules can be edited", detectors_spec Signed-off-by: Chris Hesterman <phestech@amazon.com> * Remove parens in # of rules assertion, detectors_spec Signed-off-by: Chris Hesterman <phestech@amazon.com> * Zeroing in on remote workflow fail, detectors_spec Signed-off-by: Chris Hesterman <phestech@amazon.com> Tests have been passing locally all along Signed-off-by: Chris Hesterman <phestech@amazon.com> * Reproduced issue with detectors_spec locally, fixed Signed-off-by: Chris Hesterman <phestech@amazon.com> * Small changes to detectors_spec Signed-off-by: Chris Hesterman <phestech@amazon.com> * Add wait time to allow rules to load-detectors_spec Signed-off-by: Chris Hesterman <phestech@amazon.com> * Change selector for rule search result Signed-off-by: Chris Hesterman <phestech@amazon.com> * Update selector, add mapping during creation, detectors_spec Signed-off-by: Chris Hesterman <phestech@amazon.com> * Add timeout after create button clicked Signed-off-by: Chris Hesterman <phestech@amazon.com> * Change timeout to wait before create Signed-off-by: Chris Hesterman <phestech@amazon.com> * Modify selector for button not getting clicked Signed-off-by: Chris Hesterman <phestech@amazon.com> * Remove "force: true" from troublesome clicks Signed-off-by: Chris Hesterman <phestech@amazon.com> Signed-off-by: Chris Hesterman <phestech@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 269be07 from #110