Fix issue in HashingStoredFieldVisitor with stored fields#4826
Merged
willyborankin merged 5 commits intoopensearch-project:mainfrom Oct 21, 2024
Merged
Fix issue in HashingStoredFieldVisitor with stored fields#4826willyborankin merged 5 commits intoopensearch-project:mainfrom
willyborankin merged 5 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4826 +/- ##
==========================================
- Coverage 70.99% 70.89% -0.10%
==========================================
Files 310 310
Lines 20938 20946 +8
Branches 3326 3331 +5
==========================================
- Hits 14865 14850 -15
- Misses 4325 4344 +19
- Partials 1748 1752 +4
|
Signed-off-by: Craig Perkins <cwperx@amazon.com>
nibix
approved these changes
Oct 21, 2024
willyborankin
approved these changes
Oct 21, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 8d7259d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
nibix
added a commit
to nibix/security
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Nils Bandener <nils.bandener@eliatra.com>
nibix
added a commit
to nibix/security
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Nils Bandener <nils.bandener@eliatra.com>
nibix
added a commit
to nibix/security
that referenced
this pull request
Nov 13, 2024
Signed-off-by: Nils Bandener <nils.bandener@eliatra.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug inside HashingStoredFieldVisitor to account for stored_fields which are stored separately from
_sourcein the backing index. This PR also adds integ tests to verify the correct behavior.Bug fix
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.