OnBehalfOf tokens odds and ends#3593
Merged
DarshitChanpura merged 4 commits intoopensearch-project:mainfrom Oct 27, 2023
Merged
OnBehalfOf tokens odds and ends#3593DarshitChanpura merged 4 commits intoopensearch-project:mainfrom
DarshitChanpura merged 4 commits intoopensearch-project:mainfrom
Conversation
I was doing some inspection around the OBO feature and noticed some items to clean up. Signed-off-by: Peter Nied <petern@amazon.com>
peternied
commented
Oct 24, 2023
src/main/java/org/opensearch/security/action/onbehalf/CreateOnBehalfOfTokenAction.java
Show resolved
Hide resolved
peternied
commented
Oct 24, 2023
Signed-off-by: Peter Nied <petern@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #3593 +/- ##
===========================================
+ Coverage 0 43.97% +43.97%
- Complexity 0 2502 +2502
===========================================
Files 0 283 +283
Lines 0 20621 +20621
Branches 0 3391 +3391
===========================================
+ Hits 0 9068 +9068
- Misses 0 10368 +10368
- Partials 0 1185 +1185
|
RyanL1997
reviewed
Oct 24, 2023
Collaborator
RyanL1997
left a comment
There was a problem hiding this comment.
Hi @peternied , thanks for making these changes. Here are some comments:
src/main/java/org/opensearch/security/action/onbehalf/CreateOnBehalfOfTokenAction.java
Show resolved
Hide resolved
src/main/java/org/opensearch/security/action/onbehalf/CreateOnBehalfOfTokenAction.java
Show resolved
Hide resolved
RyanL1997
reviewed
Oct 25, 2023
src/main/java/org/opensearch/security/action/onbehalf/CreateOnBehalfOfTokenAction.java
Show resolved
Hide resolved
Member
Author
|
FYI - I've got some merge conflicts and test failures to look into. |
stephen-crawford
previously approved these changes
Oct 26, 2023
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
cwperks
approved these changes
Oct 27, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3593-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9e26b15dd8d00150bed000afa9a2519e155236d2
# Push it to GitHub
git push --set-upstream origin backport/backport-3593-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.xThen, create a pull request where the |
RyanL1997
pushed a commit
to RyanL1997/security
that referenced
this pull request
Nov 2, 2023
I was doing some inspection around the OBO feature and noticed some items to clean up. Signed-off-by: Peter Nied <petern@amazon.com>
This was referenced Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was doing some inspection around the OBO feature and noticed some items to clean up.
Testing
Unit + Integration tests
Check List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.