Forward port integration tests#3512
Merged
peternied merged 7 commits intoopensearch-project:mainfrom Oct 11, 2023
Merged
Conversation
Test framework that allows for declaring within the test class all related users, roles, and other security primitives. Emphasis on hamcrest Matchers for straight forward to read, author, and troubleshoot test cases. Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: Peter Nied <peternied@hotmail.com> Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
…requests (opensearch-project#3418) (opensearch-project#3496) Backport f7c47af from opensearch-project#3495 --------- Signed-off-by: Peter Nied <petern@amazon.com> Co-authored-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #3512 +/- ##
============================================
+ Coverage 64.71% 64.73% +0.02%
- Complexity 3616 3620 +4
============================================
Files 281 281
Lines 20570 20585 +15
Branches 3400 3400
============================================
+ Hits 13312 13326 +14
Misses 5557 5557
- Partials 1701 1702 +1
|
Member
|
@peternied The version increment PR in this repo is currently blocked because the PR to add the extension points for the header verifier has not been merged into 2.x yet: opensearch-project/OpenSearch#10442 |
Signed-off-by: Peter Nied <petern@amazon.com>
2 tasks
Signed-off-by: Peter Nied <petern@amazon.com>
DarshitChanpura
requested changes
Oct 10, 2023
Member
DarshitChanpura
left a comment
There was a problem hiding this comment.
This change looks good. I have request changes related to HTTPClient 4 as the main is already on hc 5.
src/integrationTest/java/org/opensearch/security/http/BasicAuthWithoutChallengeTests.java
Show resolved
Hide resolved
peternied
commented
Oct 10, 2023
Signed-off-by: Peter Nied <petern@amazon.com>
DarshitChanpura
approved these changes
Oct 11, 2023
RyanL1997
approved these changes
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forward ports integration test changes from 2.11 and 2.x branches
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.