Skip to content

[Backport 2.x] Allow customization of netty channel handles before and during decompression#10442

Merged
peternied merged 2 commits intoopensearch-project:2.xfrom
cwperks:backport-10261-2.x
Oct 10, 2023
Merged

[Backport 2.x] Allow customization of netty channel handles before and during decompression#10442
peternied merged 2 commits intoopensearch-project:2.xfrom
cwperks:backport-10261-2.x

Conversation

@cwperks
Copy link
Copy Markdown
Member

@cwperks cwperks commented Oct 6, 2023

Manual backport of #10261 to 2.x.

There are differences in the netty pipeline between main and 2.x (mainly around http2). This PR updates the test to accommodate for the differences.

@cwperks
[2.x] Introduce header verifier step in netty pipeline
0bb45a2 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 6, 2023 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change e7d0bed

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

@cwperks
Copy link
Copy Markdown
Member Author

cwperks commented Oct 10, 2023

@peternied Can you re-run the CI on this PR and get it merged to the 2.x line?

@cwperks cwperks mentioned this pull request Oct 10, 2023
Merged
3 tasks
@peternied
Copy link
Copy Markdown
Member

peternied commented Oct 10, 2023

@cwperks Could you '+1' existing or create issues for the random failures associated with the first CI run [1]? I've re-trigged the CI run

Test Params
org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure
org.opensearch.search.scroll.SearchScrollWithFailingNodesIT.testScanScrollWithShardExceptions {p0={"search.concurrent_segment_search.enabled":"true"}}
org.opensearch.search.scroll.SearchScrollWithFailingNodesIT.testScanScrollWithShardExceptions {p0={"search.concurrent_segment_search.enabled":"false"}}

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 10, 2023

Gradle Check (Jenkins) Run Completed with:

@peternied
Copy link
Copy Markdown
Member

peternied commented Oct 10, 2023 

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':distribution:bwc:minor:buildBwcLinuxTar'.
> Building 2.10.0 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/minor/build/bwc/checkout-2.10/distribution/archives/linux-tar/build/distributions/opensearch-min-2.10.0-SNAPSHOT-linux-x64.tar.gz

@cwperks cwperks mentioned this pull request Oct 10, 2023
Closed
@cwperks
Copy link
Copy Markdown
Member Author

cwperks commented Oct 10, 2023

@peternied all of the flaky tests have corresponding issues associated with them. I added +1 or a comment on each issue.

@peternied peternied mentioned this pull request Oct 10, 2023
Closed
@DarshitChanpura
Copy link
Copy Markdown
Member

DarshitChanpura commented Oct 10, 2023 •
edited
Loading

Can we get a prioritized review on this? This is blocking 2.12 version bump: opensearch-project/security#3498 which in turn is blocking build on main due to backward-compatibility test expecting 2.12

@peternied
Copy link
Copy Markdown
Member

peternied commented Oct 10, 2023

@DarshitChanpura I'm be monitoring this

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 10, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}

@peternied peternied merged commit 760838e into opensearch-project:2.x Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peternied peternied peternied approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE

@dblock dblock Awaiting requested review from dblock

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@VachaShah VachaShah Awaiting requested review from VachaShah

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cwperks @peternied @DarshitChanpura